Fix subsheet RTL.

Improved tabbed options subsheets.

1. Fix subsheet RTL.

for the record, and to whom it may concern:

"""
If neither 'left' nor 'right' is 'auto', the position is over-constrained, and one of them has to be ignored. If the 'direction' property of the containing block is 'ltr, the value of 'left' wins and 'right' becomes -'left'. If 'direction' of the containing block is 'rtl', 'right' wins and 'left' is ignored.
"""

2. add handlers to the body element to remove the subsheets when the user clicks outside them.

BUG=67849
TEST=
1. LANGUAGE=he_IL.utf-8 ./out/Release/chrome (looks right)
2. clicking away from the subsheets to dismiss them should still work.
3. clicking to the right (in ltr) of the subsheets should dismiss them (this is new)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71724

[Evan Stade, 2011-01-15 01:33:20]

stuart: please download and apply this, and fiddle with it to make sure it
doesn't get anything wrong

[stuartmorgan, 2011-01-18 17:21:52]

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:218: width: 680px;
Won't this make the visible sub-pages 16px narrower than they are supposed to
be?

[arv (Not doing code reviews), 2011-01-18 19:06:07]

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:209: -webkit-padding-start:
0px;
s/0px/0/

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:326:
document.body.addEventListener('click', this.bodyMouseEventHandler_(),
Use bind instead?

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:374: * @return {function} a
function to handle mouse events while a subpage is
{Function}

only value types are lower case

[Evan Stade, 2011-01-18 22:37:09]

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:209: -webkit-padding-start:
0px;
On 2011/01/18 19:06:07, arv wrote:
> s/0px/0/

Done.

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:218: width: 680px;
On 2011/01/18 17:21:52, stuartmorgan wrote:
> Won't this make the visible sub-pages 16px narrower than they are supposed to
> be?

yes, good catch. (actually, it was off by 8)

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.js (right):

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:326:
document.body.addEventListener('click', this.bodyMouseEventHandler_(),
On 2011/01/18 19:06:07, arv wrote:
> Use bind instead?

Done.

http://codereview.chromium.org/6277005/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.js:374: * @return {function} a
function to handle mouse events while a subpage is
On 2011/01/18 19:06:07, arv wrote:
> {Function}
> 
> only value types are lower case

Done.

[stuartmorgan, 2011-01-18 22:48:04]

LGTM

http://codereview.chromium.org/6277005/diff/10001/chrome/browser/resources/op...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6277005/diff/10001/chrome/browser/resources/op...
chrome/browser/resources/options/options_page.css:196: -webkit-padding-start: 0;
I think this has to be after padding..

[arv (Not doing code reviews), 2011-01-18 23:47:28]

LGTM