Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 6277003: Simplified MessageReader and MessageDecoder classes. (Closed)

Created:
9 years, 11 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, dmac, awong, garykac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Simplified MessageReader and MessageDecoder classes. Now these two classes are not templates, and just handle raw data. New ProtobufMessageReader is used to parse messages. BUG=None TEST=Unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71497

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -164 lines) Patch
M remoting/protocol/client_message_dispatcher.h View 3 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/client_message_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/host_message_dispatcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/host_message_dispatcher.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_connection_to_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/message_decoder.h View 1 1 chunk +16 lines, -49 lines 0 comments Download
M remoting/protocol/message_decoder.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M remoting/protocol/message_reader.h View 2 chunks +42 lines, -62 lines 0 comments Download
M remoting/protocol/message_reader.cc View 1 2 chunks +21 lines, -11 lines 0 comments Download
M remoting/protocol/protobuf_video_reader.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/protobuf_video_reader.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M remoting/protocol/rtp_video_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/rtp_video_reader.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/protocol/socket_reader_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/socket_reader_base.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M remoting/protocol/video_reader.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sergey Ulanov
Also removed Close() method where we don't need it.
9 years, 11 months ago (2011-01-14 02:30:34 UTC) #1
Alpha Left Google
LGTM. So the next patch will be changing to pull by adding the done task?
9 years, 11 months ago (2011-01-14 19:38:41 UTC) #2
Sergey Ulanov
9 years, 11 months ago (2011-01-14 19:59:03 UTC) #3
On 2011/01/14 19:38:41, Alpha wrote:
> LGTM. So the next patch will be changing to pull by adding the done task?
Yes.

Powered by Google App Engine
This is Rietveld 408576698