Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5052)

Unified Diff: chrome/test/functional/downloads.py

Issue 6275016: Fix flaky testZipInIncognito (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/downloads.py
diff --git a/chrome/test/functional/downloads.py b/chrome/test/functional/downloads.py
index 0e7dda3bc266947a0405841a05ebe6cb2ea7b758..ceadd88668931edf3b7100b18cfb574246a136f0 100644
--- a/chrome/test/functional/downloads.py
+++ b/chrome/test/functional/downloads.py
@@ -138,6 +138,9 @@ class DownloadsTest(pyauto.PyUITest):
# Trigger download and wait in new incognito window.
self.DownloadAndWaitForStart(file_url, 1)
self.WaitForAllDownloadsToComplete(1)
+ # Remove next line when WaitForAllDownloadsToComplete can reliably wait
+ # for downloads in incognito window. crbug.com/69738
+ self.WaitForDownloadToComplete(downloaded_pkg)
incognito_downloads = self.GetDownloadsInfo(1).Downloads()
# Verify that download info exists in the correct profile.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698