Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 6275013: Fixed suppressions that were not updated after namespace rename. (Closed)

Created:
9 years, 11 months ago by pastarmovj
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fixed suppressions that were not updated after namespace rename. s/5NPAPI/6webkit5npapi/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72319

Patch Set 1 #

Patch Set 2 : One more ... line needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 3 chunks +4 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pastarmovj
John, I am sorry for bothering you again but I am sure you can have ...
9 years, 11 months ago (2011-01-21 17:09:31 UTC) #1
jam
9 years, 11 months ago (2011-01-21 17:25:52 UTC) #2
lgtm

On Fri, Jan 21, 2011 at 9:09 AM, <pastarmovj@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Message:
> John, I am sorry for bothering you again but I am sure you can have a look
> at
> this change in a minute it is a straightforward search/replace in the
> suppressions list of NPAPI with webkit::npapi as this has changed but the
> suppressions were not updated accordingly and PluginList now reports some
> false
> positives because of that. And it will be great to land this suppression
> fix
> before the refactoring CL to not increase the memory buildbots turbulence.
>
> Description:
> Fixed suppressions that were not updated after namespace rename.
>
> s/5NPAPI/6webkit5npapi/
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6275013/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/tools
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions.txt
>  M tools/valgrind/memcheck/suppressions_mac.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
27c308fbf03eb29311531ccb18a26853aa015c13..ec82ef60891aa53e7d29ee770e5cc7465aef6b68
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -271,7 +271,7 @@
>    bug_21326
>    Memcheck:Leak
>    ...
> -   fun:_ZN5NPAPI9PluginLib17ReadWebPluginInfoERK8FilePathP13WebPluginInfo
> +
> fun:_ZN56webkit5npapi9PluginLib17ReadWebPluginInfoERK8FilePathP13WebPluginInfo
>  }
>  {
>    # NSS bug https://bugzilla.mozilla.org/show_bug.cgi?id=518443
> @@ -3355,7 +3355,8 @@
>    fun:_Znw*
>    ...
>    fun:_ZNSt*
> -   fun:_ZN5NPAPI10PluginList*
> +   ...
> +   fun:_ZN6webkit5npapi10PluginList*
>    ...
>    fun:_ZN13PluginService*
>  }
> @@ -3653,4 +3654,4 @@
>    fun:_ZN9talk_base12MessageQueue8DispatchEPNS_7MessageE
>    fun:_ZN9talk_base6Thread15ProcessMessagesEi
>  }
> -
> \ No newline at end of file
> +
> Index: tools/valgrind/memcheck/suppressions_mac.txt
> diff --git a/tools/valgrind/memcheck/suppressions_mac.txt
> b/tools/valgrind/memcheck/suppressions_mac.txt
> index
>
2b78ed4e891c6598603ef8e5bd9cd2fa5b68a507..f8b897d4a3801d9c09ad0ae8f1a788cfc6c1d474
> 100644
> --- a/tools/valgrind/memcheck/suppressions_mac.txt
> +++ b/tools/valgrind/memcheck/suppressions_mac.txt
> @@ -939,9 +939,9 @@
>    ...
>    fun:FSFindFolder
>
>  fun:_ZN12_GLOBAL__N_124GetPluginCommonDirectoryEPSt6vectorI8FilePathSaIS1_EEb
> -
> fun:_ZN5NPAPI10PluginList20GetPluginDirectoriesEPSt6vectorI8FilePathSaIS2_EE
> -   fun:_ZN5NPAPI10PluginList11LoadPluginsEb
> -
> fun:_ZN5NPAPI10PluginList10GetPluginsEbPSt6vectorI13WebPluginInfoSaIS2_EE
> +
>
fun:_ZN6webkit5npapi10PluginList20GetPluginDirectoriesEPSt6vectorI8FilePathSaIS2_EE
> +   fun:_ZN6webkit5npapi10PluginList11LoadPluginsEb
> +
>
fun:_ZN6webkit5npapi10PluginList10GetPluginsEbPSt6vectorI13WebPluginInfoSaIS2_EE
>    fun:_ZN13PluginUpdater30GetPreferencesDataOnFileThreadEPv
>  }
>  {
> @@ -950,9 +950,9 @@
>    ...
>    fun:FSFindFolder
>
>  fun:_ZN12_GLOBAL__N_124GetPluginCommonDirectoryEPSt6vectorI8FilePathSaIS1_EEb
> -
> fun:_ZN5NPAPI10PluginList20GetPluginDirectoriesEPSt6vectorI8FilePathSaIS2_EE
> -   fun:_ZN5NPAPI10PluginList11LoadPluginsEb
> -
> fun:_ZN5NPAPI10PluginList10GetPluginsEbPSt6vectorI13WebPluginInfoSaIS2_EE
> +
>
fun:_ZN6webkit5npapi10PluginList20GetPluginDirectoriesEPSt6vectorI8FilePathSaIS2_EE
> +   fun:_ZN6webkit5npapi10PluginList11LoadPluginsEb
> +
>
fun:_ZN6webkit5npapi10PluginList10GetPluginsEbPSt6vectorI13WebPluginInfoSaIS2_EE
>    fun:_ZN13PluginUpdater30GetPreferencesDataOnFileThreadEPv
>  }
>  {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698