DCHECK(result) keeps firing in AutocompleteHistoryManager::OnWebDataServiceRequestDone()

chrome/browser/autocomplete_history_manager.cc

Index: chrome/browser/autocomplete_history_manager.cc
diff --git a/chrome/browser/autocomplete_history_manager.cc b/chrome/browser/autocomplete_history_manager.cc
index 40d8c72fae0383cf62da65125ca89af9c10c59c0..558a235b7aa1f3c04bda9abf054e9701246de00d 100644
--- a/chrome/browser/autocomplete_history_manager.cc
+++ b/chrome/browser/autocomplete_history_manager.cc
@@ -175,6 +175,13 @@ void AutocompleteHistoryManager::OnWebDataServiceRequestDone(
   }
 
   DCHECK(result);
+  // Returning early here if |result| is NULL.  We've seen this happen on
+  // Linux due to NFS dismouting and causing sql failures. See crbug.com/68783.

[Ilya Sherman, 2011/01/21 01:58:09]

nit: http://crbug.com/68783

[willchan no longer on Chromium, 2011/01/21 02:01:27]

NFS dismounting.

[dhollowa, 2011/01/21 02:05:41]

Done.  But there's a mix of the two forms in the code base.

[dhollowa, 2011/01/21 02:05:41]

Done.

+  if (!result) {
+    SendSuggestions(NULL);
+    return;
+  }
+
   DCHECK(result->GetType() == AUTOFILL_VALUE_RESULT);
   const WDResult<std::vector<string16> >* autofill_result =
       static_cast<const WDResult<std::vector<string16> >*>(result);