DCHECK(result) keeps firing in AutocompleteHistoryManager::OnWebDataServiceRequestDone()

DCHECK(result) keeps firing in AutocompleteHistoryManager::OnWebDataServiceRequestDone()

A NULL |result| should DCHECK, but not crash.  This is a short term solution to the top-crasher, will still DCHECK for devs while a longer term fix is determined.

BUG=68783, 69833
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72094

[Ilya Sherman, 2011-01-21 01:58:09]

LGTM

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
File chrome/browser/autocomplete_history_manager.cc (right):

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
chrome/browser/autocomplete_history_manager.cc:179: // Linux due to NFS
dismouting and causing sql failures. See crbug.com/68783.
nit: http://crbug.com/68783

[willchan no longer on Chromium, 2011-01-21 02:01:27]

LGTM

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
File chrome/browser/autocomplete_history_manager.cc (right):

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
chrome/browser/autocomplete_history_manager.cc:179: // Linux due to NFS
dismouting and causing sql failures. See crbug.com/68783.
On 2011/01/21 01:58:09, Ilya Sherman wrote:
> nit: http://crbug.com/68783

NFS dismounting.

[dhollowa, 2011-01-21 02:05:41]

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
File chrome/browser/autocomplete_history_manager.cc (right):

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
chrome/browser/autocomplete_history_manager.cc:179: // Linux due to NFS
dismouting and causing sql failures. See crbug.com/68783.
On 2011/01/21 01:58:09, Ilya Sherman wrote:
> nit: http://crbug.com/68783

Done.  But there's a mix of the two forms in the code base.

http://codereview.chromium.org/6275011/diff/1/chrome/browser/autocomplete_his...
chrome/browser/autocomplete_history_manager.cc:179: // Linux due to NFS
dismouting and causing sql failures. See crbug.com/68783.
On 2011/01/21 02:01:27, willchan wrote:
> On 2011/01/21 01:58:09, Ilya Sherman wrote:
> > nit: http://crbug.com/68783
> 
> NFS dismounting.

Done.