Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 6275010: Force patches that touch sync code to use the sync trybots (Closed)

Created:
9 years, 11 months ago by Raghu Simha
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana
Visibility:
Public.

Description

Force patches that touch sync code to use the sync trybots As of today, we have dedicated chromium trybots that can run the sync integration tests, but it requires developers to explicitly send try jobs to these bots via the --bot switch. Now that the sync trybots are stable, it is time to make this process automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that adds the sync trybots in addition to win, mac and linux to the list of preferred trybots. This patch adds such a PRESUBMIT.py file, that includes win_sync, mac_sync and linux_sync to the list of preferred trybots. BUG=70311 TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
chrome/browser/sync/PRESUBMIT.py View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
Tim, please review.
9 years, 11 months ago (2011-01-21 00:11:34 UTC) #1
tim (not reviewing)
9 years, 11 months ago (2011-01-21 00:17:26 UTC) #2
1337

LGTM

Powered by Google App Engine
This is Rietveld 408576698