Enable NaCl UI test to test basic integration between Chrome and NaCl

Enable NaCl UI test to test basic integration between Chrome and NaCl

Contains NaCl roll as well to pick up the test data.

TBR=noelallen


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71929

[noelallen_use_chromium, 2011-01-20 09:39:57]

LGTM, but I would prefer a comment explaining why this was disabled.

http://codereview.chromium.org/6275007/diff/1/chrome/test/nacl/nacl_ui_test.cc
File chrome/test/nacl/nacl_ui_test.cc (right):

http://codereview.chromium.org/6275007/diff/1/chrome/test/nacl/nacl_ui_test.c...
chrome/test/nacl/nacl_ui_test.cc:80: // TEST_F(NaClUITest,
DISABLED_MultiarchTest) {
Could you add a comment as to why this was disabled?  So we know if something is
broken that shouldn't be, or if we are planning to support this later, etc...

[abarth-chromium, 2011-01-20 09:43:30]

Oh, that test is already disabled.  I just commented it out because it
was using a variable I renamed.  The disabled tests should just be
deleted, IMHO.

Adam


On Thu, Jan 20, 2011 at 1:39 AM,  <noelallen@google.com> wrote:
> LGTM, but I would prefer a comment explaining why this was disabled.
>
>
> http://codereview.chromium.org/6275007/diff/1/chrome/test/nacl/nacl_ui_test.cc
> File chrome/test/nacl/nacl_ui_test.cc (right):
>
>
http://codereview.chromium.org/6275007/diff/1/chrome/test/nacl/nacl_ui_test.c...
> chrome/test/nacl/nacl_ui_test.cc:80: // TEST_F(NaClUITest,
> DISABLED_MultiarchTest) {
> Could you add a comment as to why this was disabled?  So we know if
> something is broken that shouldn't be, or if we are planning to support
> this later, etc...
>
> http://codereview.chromium.org/6275007/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to native-client-reviews@googlegroups.com.
> To unsubscribe from this group, send email to
> native-client-reviews+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/native-client-reviews?hl=en.
>
>