DOMUI: Handle textInput in addition to keydown for the AF cc input field.

chrome/browser/resources/options/autofill_edit_creditcard_overlay.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
 
   // The GUID of the loaded credit card.
   var guid_;
 
@@ skipping 28 matching lines @@
       OptionsPage.prototype.initializePage.call(this);
 
       var self = this;
       $('autoFillEditCreditCardCancelButton').onclick = function(event) {
         self.dismissOverlay_();
       }
       $('autoFillEditCreditCardApplyButton').onclick = function(event) {
         self.saveCreditCard_();
         self.dismissOverlay_();
       }
-      $('creditCardNumber').onkeydown = this.onKeyDown_.bind(this);
+      $('creditCardNumber').onkeydown = this.onTextInput_.bind(this);
+      $('creditCardNumber').addEventListener('textInput',

[arv (Not doing code reviews), 2011/01/26 18:17:07]

Should this be 'input' like everywhere else?

+                                             this.onTextInput_.bind(this));
 
       self.guid_ = '';
       self.storedCCNumber_ = '';
       self.hasEditedNumber_ = false;
       self.clearInputFields_();
       self.connectInputEvents_();
       self.setDefaultSelectOptions_();
     },
 
     /**
-     * Handles the keydown event.
+     * Handles the textInput and keydown events.
      * @private
      */
-    onKeyDown_: function(event) {
+    onTextInput_: function(event) {
+      // For some reason, the textInput event doesn't consider

[arv (Not doing code reviews), 2011/01/26 18:17:07]

The input event fires for all user changes to the value.

+      // backspace/deletion an input event, so we have to handle those here.
+      // 8 - backspace
+      // 46 - delete
+      if (event.type == 'keydown' && event.keyCode != '8' &&

[arv (Not doing code reviews), 2011/01/26 18:17:07]

FYI, keyCode is a Number so comparing it to a string is causes extra string
coercions and harder to read code.

+          event.keyCode != '46')
+        return;
+
       // If the user hasn't edited the text yet, delete it all on edit.
       if (!this.hasEditedNumber_ &&
           $('creditCardNumber').value != this.storedCCNumber_) {
         this.hasEditedNumber_ = true;
         $('creditCardNumber').value = '';
       }
     },
 
     /**
      * Clears any uncommitted input, and dismisses the overlay.
@@ skipping 151 matching lines @@
   AutoFillEditCreditCardOverlay.setTitle = function(title) {
     $('autoFillCreditCardTitle').textContent = title;
   };
 
   // Export
   return {
     AutoFillEditCreditCardOverlay: AutoFillEditCreditCardOverlay
   };
 
 });