Issue 6274010: DOMUI: Handle textInput in addition to keydown for the AF cc input field.

Issue 6274010: DOMUI: Handle textInput in addition to keydown for the AF cc input field. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), Ilya Sherman, dhollowa

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Handle textInput in addition to keydown for the AF cc input field. BUG=70452 TEST=none

Patch Set 2 : Handle delete too. #

Total comments: 3

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/browser/resources/options/autofill_edit_creditcard_overlay.js	View	1	2 chunks	+13 lines, -3 lines	3 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dhollowa

http://codereview.chromium.org/6274010/diff/1/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js File chrome/browser/resources/options/autofill_edit_creditcard_overlay.js (right): http://codereview.chromium.org/6274010/diff/1/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js#newcode66 chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:66: if (event.type == 'keydown' && event.keyCode != '8') What ...

9 years, 11 months ago (2011-01-26 01:57:04 UTC) #2

James Hawkins

9 years, 11 months ago (2011-01-26 01:59:47 UTC) #3

arv (Not doing code reviews)

9 years, 11 months ago (2011-01-26 18:17:07 UTC) #6

http://codereview.chromium.org/6274010/diff/3001/chrome/browser/resources/opt...
File chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
(right):

http://codereview.chromium.org/6274010/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:50:
$('creditCardNumber').addEventListener('textInput',
Should this be 'input' like everywhere else?

http://codereview.chromium.org/6274010/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:66: // For
some reason, the textInput event doesn't consider
The input event fires for all user changes to the value.

http://codereview.chromium.org/6274010/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:70: if
(event.type == 'keydown' && event.keyCode != '8' &&
FYI, keyCode is a Number so comparing it to a string is causes extra string
coercions and harder to read code.

Expand Messages | Collapse Messages