Issue 6274: Greasemonkey support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6274: Greasemonkey support. (Closed)

Created:
12 years, 2 months ago by Evan Martin

Modified:
6 years, 6 months ago

Reviewers:
Peter Kasting, M-A Ruel

CC:
chromium-reviews_googlegroups.com, aa

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -23 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/debugger/debugger_view.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_host.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/render_view_host.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/render_view_host.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/web_contents.cc	View	3 chunks	+138 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	chrome/common/chrome_paths.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/debug_message_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	2 chunks	+9 lines, -6 lines	1 comment	Download
M	webkit/glue/webframe.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Pretty neat. http://codereview.chromium.org/6274/diff/1/9 File chrome/common/chrome_paths.h (right): http://codereview.chromium.org/6274/diff/1/9#newcode27 Line 27: DIR_USER_SCRIPTS, Please comment it. http://codereview.chromium.org/6274/diff/1/12 File ...

12 years, 2 months ago (2008-10-06 17:30:44 UTC) #1

Peter Kasting

12 years, 2 months ago (2008-10-06 17:38:10 UTC) #2

You should get Boodman to review this, not just because it would be a good idea,
but also because it might conflict with his extension system ideas.  I think he
wanted to avoid supporting Greasemonkey immediately in hopes of doing something
with enhanced capabilities that wasn't totally compatible -- this might lock us
in to supporting an API we didn't want to?

Expand Messages | Collapse Messages

Issue 6274: Greasemonkey support. (Closed)

Description

Patch Set 1 #

Messages