Issue 6273012: Make make_bmp_images work specially on ARM

Issue 6273012: Make make_bmp_images work specially on ARM (Closed)

Created:
9 years, 11 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Randall Spangler, Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

On ARM, we need output geometry same as screen size instead of 800x600 and use 8bpp RLE format to encoding BMP. Also make the script able to run at other directory. BUG=chromium-os:11384 TEST=as follow: $ cd /tmp $ ~/$CHROMEOS/src/platform/vboot_reference/scripts/bitmaps/make_bmp_images.sh 'x86 HWID 1234' '1366x768' true processing BlankBmp ... processing DeveloperBmp ... processing RecoveryBmp ... processing RecoveryMissingOSBmp ... processing RecoveryNoOSBmp ... $ file out_x86_HWID_1234/DeveloperBmp/DeveloperBmp.bmp out_x86_HWID_1234/DeveloperBmp/DeveloperBmp.bmp: PC bitmap, Windows 3.x format, 800 x 600 x 24 $ ~/$CHROMEOS/src/platform/vboot_reference/scripts/bitmaps/make_bmp_images.sh 'arm HWID 1234' '1366x768' false processing BlankBmp ... processing DeveloperBmp ... processing RecoveryBmp ... processing RecoveryMissingOSBmp ... processing RecoveryNoOSBmp ... $ file out_arm_HWID_1234/DeveloperBmp/DeveloperBmp.bmp out_arm_HWID_1234/DeveloperBmp/DeveloperBmp.bmp: PC bitmap, Windows 3.x format, 1366 x 768 x 8 Change-Id: Ia96a4e64f34350f8bd5fec51657d3cec85c4ab1c Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ab96acf

Patch Set 1 #

Patch Set 2 : ready for review #

Patch Set 3 : rename makeline to makeline.sh #

Total comments: 2

Patch Set 4 : use x86/arm as argument #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
M	scripts/bitmaps/make_bmp_images.sh	View	1 2 3	4 chunks	+20 lines, -15 lines	0 comments	Download
A +	scripts/bitmaps/makelines.sh	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	scripts/bitmaps/process_all_targets.sh	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

One suggestion. http://codereview.chromium.org/6273012/diff/4002/scripts/bitmaps/make_bmp_images.sh File scripts/bitmaps/make_bmp_images.sh (right): http://codereview.chromium.org/6273012/diff/4002/scripts/bitmaps/make_bmp_images.sh#newcode17 scripts/bitmaps/make_bmp_images.sh:17: if [ $# -ne "3" -o \( ...

9 years, 10 months ago (2011-01-27 17:46:28 UTC) #2

Tom Wai-Hong Tam

http://codereview.chromium.org/6273012/diff/4002/scripts/bitmaps/make_bmp_images.sh File scripts/bitmaps/make_bmp_images.sh (right): http://codereview.chromium.org/6273012/diff/4002/scripts/bitmaps/make_bmp_images.sh#newcode17 scripts/bitmaps/make_bmp_images.sh:17: if [ $# -ne "3" -o \( $3 != ...

9 years, 10 months ago (2011-01-28 01:24:02 UTC) #3

LGTM

Expand Messages | Collapse Messages