Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 6273010: [linux] When the user has the notification options menu, delay system-initiat... (Closed)

Created:
9 years, 11 months ago by John Gregg
Modified:
9 years ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews
Visibility:
Public.

Description

[linux] When the user has the notification options menu, delay system-initiated closing of the notification. BUG=51177 TEST=open the notification options menu on a notification which will be auto-closed by the page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
John Gregg
9 years, 11 months ago (2011-01-25 01:36:48 UTC) #1
Dmitry Titov
9 years, 11 months ago (2011-01-25 02:02:58 UTC) #2
LGTM

I wish there was a test for this.

Powered by Google App Engine
This is Rietveld 408576698