Issue 6273006: Added CHECK for buffer_ and xml_wrapper_ to be not NULL ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6273006: Added CHECK for buffer_ and xml_wrapper_ to be not NULL ... (Closed)

Created:
9 years, 11 months ago by raman

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Added CHECK for buffer_ and xml_wrapper_ to be not NULL before accessing them. BUG=64813 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71564

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/metrics_helpers.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

rtenneti

Hi Jim, Added CHECK for buffer_ and xml_wrapper_ to be not NULL to catch it ...

9 years, 11 months ago (2011-01-15 02:11:13 UTC) #1

LGTM