Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/extensions/external_extension_loader.cc

Issue 6272025: Part 2 of repairing regressions to my old clang check plugins so Nico can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Copyright 2011 Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/external_extension_loader.h" 5 #include "chrome/browser/extensions/external_extension_loader.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/browser_thread.h" 9 #include "chrome/browser/browser_thread.h"
10 #include "chrome/browser/extensions/external_extension_provider_impl.h" 10 #include "chrome/browser/extensions/external_extension_provider_impl.h"
11 11
12 ExternalExtensionLoader::ExternalExtensionLoader() : running_(false) {}
13
12 void ExternalExtensionLoader::Init( 14 void ExternalExtensionLoader::Init(
13 ExternalExtensionProviderImpl* owner) { 15 ExternalExtensionProviderImpl* owner) {
14 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 16 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
15 owner_ = owner; 17 owner_ = owner;
16 } 18 }
17 19
18 const FilePath ExternalExtensionLoader::GetBaseCrxFilePath() { 20 const FilePath ExternalExtensionLoader::GetBaseCrxFilePath() {
19 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 21 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
20 22
21 // By default, relative paths are not supported. 23 // By default, relative paths are not supported.
22 // Subclasses that wish to support them should override this method. 24 // Subclasses that wish to support them should override this method.
23 return FilePath(); 25 return FilePath();
24 } 26 }
25 27
26 void ExternalExtensionLoader::OwnerShutdown() { 28 void ExternalExtensionLoader::OwnerShutdown() {
27 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 29 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
28 owner_ = NULL; 30 owner_ = NULL;
29 } 31 }
30 32
33 ExternalExtensionLoader::~ExternalExtensionLoader() {}
34
31 void ExternalExtensionLoader::LoadFinished() { 35 void ExternalExtensionLoader::LoadFinished() {
32 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 36 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
33 running_ = false; 37 running_ = false;
34 if (owner_) { 38 if (owner_) {
35 owner_->SetPrefs(prefs_.release()); 39 owner_->SetPrefs(prefs_.release());
36 } 40 }
37 } 41 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/external_extension_loader.h ('k') | chrome/browser/extensions/external_pref_extension_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698