Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5066)

Unified Diff: chrome/browser/speech/speech_input_bubble_gtk.cc

Issue 6272018: Fix speech input bubble in GTK to avoid setting images when not visible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: applying changes suggested by Satish. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/speech_input_bubble_gtk.cc
diff --git a/chrome/browser/speech/speech_input_bubble_gtk.cc b/chrome/browser/speech/speech_input_bubble_gtk.cc
index 95c183fa6da77db6bcdc81ee813b8070df3e33e6..a8079b6cd6c0451af1c2e8be478a7652f4671f5c 100644
--- a/chrome/browser/speech/speech_input_bubble_gtk.cc
+++ b/chrome/browser/speech/speech_input_bubble_gtk.cc
@@ -196,7 +196,7 @@ void SpeechInputBubbleGtk::UpdateLayout() {
}
void SpeechInputBubbleGtk::SetImage(const SkBitmap& image) {
- if (image.isNull())
+ if (image.isNull() || !info_bubble_)
return;
GdkPixbuf* pixbuf = gfx::GdkPixbufFromSkBitmap(&image);
@@ -212,4 +212,3 @@ SpeechInputBubble* SpeechInputBubble::CreateNativeBubble(
const gfx::Rect& element_rect) {
return new SpeechInputBubbleGtk(tab_contents, delegate, element_rect);
}
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698