Issue 6272018: Fix speech input bubble in GTK to avoid setting images when not visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6272018: Fix speech input bubble in GTK to avoid setting images when not visible. (Closed)

Created:
9 years, 11 months ago by Leandro Graciá Gil

Modified:
9 years, 7 months ago

Reviewers:
Satish

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix speech input bubble in GTK to avoid setting images when not visible. The visibility of the speech input bubble was not being checked when a image was requested to be set. Consequently, this could lead to invalid image objects in some cases producing glib and GTK errors. BUG=70223 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72501

Patch Set 1 : applying changes suggested by Satish. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/speech/speech_input_bubble_gtk.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages