Issue 6272017: Disable MSVC warning that default array initializers now work properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6272017: Disable MSVC warning that default array initializers now work properly. (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Disable MSVC warning that default array initializers now work properly. Committed: http://code.google.com/p/v8/source/detail?r=6454

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	SConstruct	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/gyp/v8.gyp	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-25 11:15:39 UTC) #3

LGTM

http://codereview.chromium.org/6272017/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/6272017/diff/1/tools/gyp/v8.gyp#newcode752
tools/gyp/v8.gyp:752: # 4355, 4800 came from common.vsprops
Please remove this comment - it does not make much sense.

Expand Messages | Collapse Messages