Prevent non-Incognito windows in the Guest session.

chrome/browser/ui/browser_navigator.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_navigator.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_url_handler.h"
 #include "chrome/browser/browser_window.h"
@@ skipping 87 matching lines @@
       params->target_contents = tab;
       return i;
     }
   }
 
   return -1;
 }
 
 // Change some of the navigation parameters based on the particular URL.
 // Currently this applies to chrome://settings and the bookmark manager,
-// which we always want to open in a normal (not incognito) window.
+// which we always want to open in a normal (not incognito) window. Guest
+// session is an exception.
 void AdjustNavigateParamsForURL(browser::NavigateParams* params) {
   if (!params->target_contents &&
       params->url.scheme() == chrome::kChromeUIScheme &&
       (params->url.host() == chrome::kChromeUISettingsHost ||
        params->url.host() == chrome::kChromeUIBookmarksHost)) {
     Profile* profile =
         params->browser ? params->browser->profile() : params->profile;
 
-    if (profile->IsOffTheRecord()) {
+    if (profile->IsOffTheRecord() && !Profile::IsGuestSession()) {

[Ben Goodger (Google), 2011/01/28 19:12:08]

Can you add a unit test?

[altimofeev, 2011/01/31 16:26:40]

Added browsertest. Can you take another look?

       profile = profile->GetOriginalProfile();
 
       params->disposition = SINGLETON_TAB;
       params->profile = profile;
       params->browser = Browser::GetOrCreateTabbedBrowser(profile);
       params->show_window = true;
     }
   }
 }
 
@@ skipping 339 matching lines @@
           params->url, params->referrer, params->transition);
     }
 
     // If the singleton tab isn't already selected, select it.
     if (params->source_contents != params->target_contents)
       params->browser->SelectTabContentsAt(singleton_index, user_initiated);
   }
 }
 
 }  // namespace browser