Issue 6272015: Prepare push to trunk. We are now working on 3.0.11.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6272015: Prepare push to trunk. We are now working on 3.0.11. (Closed)

Created:
9 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. We are now working on 3.0.11. Committed: http://code.google.com/p/v8/source/detail?r=6437

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+24 lines, -0 lines	2 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 11 months ago (2011-01-24 11:57:41 UTC) #2

LGTM with a couple of small fixes.

http://codereview.chromium.org/6272015/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/6272015/diff/1/ChangeLog#newcode11
ChangeLog:11: Introduced partial strict mode support which can be enabled
Actually it is the other way. It is on by default and can be disabled with the
flag --nostrict-mode. Just state that we added partial strict mode support?

http://codereview.chromium.org/6272015/diff/1/ChangeLog#newcode14
ChangeLog:14: Changed handling of errors occured when formatting error message
to
Changed formatting of recursive error messages to match Firefox and Safari
(...).

?

Expand Messages | Collapse Messages