Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 6272012: Temporary whitelist several cases of disk I/O on the UI threads in cros. (Closed)

Created:
9 years, 11 months ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org, evanm
Visibility:
Public.

Description

Temporary whitelist several cases of disk I/O on the UI threads in cros. BUG=60211, 70097, 70119, 70131, 62626, 61143, chromium-os:11102, chromium-os:11104, chromium-os:11105, chromium-os:11106, chromium-os:11109 TEST=bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72331

Patch Set 1 #

Patch Set 2 : update comments #

Patch Set 3 : update issue id #

Patch Set 4 : remove IOThread restriction #

Patch Set 5 : merge #

Patch Set 6 : remove UI thread restriction #

Patch Set 7 : merge #

Patch Set 8 : bring UI thread restriction back, issue 11110 should be fixed #

Patch Set 9 : browser_main cleanup #

Patch Set 10 : cleanup WizardInProcessBrowserTest #

Total comments: 4

Patch Set 11 : remove UI thread restriction, nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -10 lines) Patch
M base/nss_util.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/apply_services_customization.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/help_app_launcher.cc View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 2 3 4 5 6 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/chromeos/metrics_cros_settings_provider.cc View 1 3 chunks +12 lines, -1 line 0 comments Download
M chrome/common/logging_chrome.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
Whitelisting all places that triggered during run on cros platform. WizardInProcessBrowserTest instances are broken when ...
9 years, 11 months ago (2011-01-24 11:14:46 UTC) #1
Dmitry Polukhin
LGTM if try bots pass http://codereview.chromium.org/6272012/diff/22001/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/6272012/diff/22001/chrome/browser/chromeos/login/wizard_controller.cc#newcode1021 chrome/browser/chromeos/login/wizard_controller.cc:1021: { You are already ...
9 years, 11 months ago (2011-01-24 11:32:02 UTC) #2
Nikita (slow)
9 years, 11 months ago (2011-01-24 12:55:33 UTC) #3
Trybots are fine, but I'll submit UI thread restriction as a separate CL so that
it could be easily reverted if needed.
Submitting whitelisting as is.

http://codereview.chromium.org/6272012/diff/22001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/6272012/diff/22001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller.cc:1021: {
On 2011/01/24 11:32:02, Dmitry Polukhin wrote:
> You are already in scope "if () {". There is no need for one more.

Done.

http://codereview.chromium.org/6272012/diff/22001/chrome/common/logging_chrom...
File chrome/common/logging_chrome.cc (right):

http://codereview.chromium.org/6272012/diff/22001/chrome/common/logging_chrom...
chrome/common/logging_chrome.cc:217: // Loading manifest causes us to do
blocking IO on UI thread.
On 2011/01/24 11:32:02, Dmitry Polukhin wrote:
> Copy&past issue?

Done.

Powered by Google App Engine
This is Rietveld 408576698