DOMUI: Add padding for the Home Page favicon.

DOMUI: Add padding for the Home Page favicon.

BUG=69902
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71752

[stuartmorgan, 2011-01-18 17:23:03]

What about rtl?

http://codereview.chromium.org/6272008/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6272008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:501: background-position-x:
4px;
Did you mean to change this for all the list items too? If not, it should be in
an input.favicon-cell rule.

[James Hawkins, 2011-01-18 20:05:10]

RTL fixed as well.

http://codereview.chromium.org/6272008/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6272008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:501: background-position-x:
4px;
On 2011/01/18 17:23:03, stuartmorgan wrote:
> Did you mean to change this for all the list items too? If not, it should be
in
> an input.favicon-cell rule.

Only for input; fixed.

[stuartmorgan, 2011-01-18 21:52:04]

http://codereview.chromium.org/6272008/diff/5001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6272008/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:497: background-position-x:
99.3%;
I had considered this before, but didn't quite have the guts for it ;)

Maybe put a TODO for doing something better when CSS3 background positioning is
available (which would let us do 'x pixels from the right').

[stuartmorgan, 2011-01-18 21:52:16]

Oops, forgot the LGTM

[James Hawkins, 2011-01-19 03:07:47]

http://codereview.chromium.org/6272008/diff/5001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6272008/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:497: background-position-x:
99.3%;
On 2011/01/18 21:52:05, stuartmorgan wrote:
> I had considered this before, but didn't quite have the guts for it ;)
> 
> Maybe put a TODO for doing something better when CSS3 background positioning
is
> available (which would let us do 'x pixels from the right').

Done.

[arv (Not doing code reviews), 2011-01-19 22:17:37]

I think CSS3 calc (patch is in progress) would allow us to do calc(100% - 3px)

erik

On Tue, Jan 18, 2011 at 19:07,  <jhawkins@chromium.org> wrote:
>
>
http://codereview.chromium.org/6272008/diff/5001/chrome/browser/resources/opt...
> File chrome/browser/resources/options/options_page.css (right):
>
>
http://codereview.chromium.org/6272008/diff/5001/chrome/browser/resources/opt...
> chrome/browser/resources/options/options_page.css:497:
> background-position-x: 99.3%;
> On 2011/01/18 21:52:05, stuartmorgan wrote:
>>
>> I had considered this before, but didn't quite have the guts for it ;)
>
>> Maybe put a TODO for doing something better when CSS3 background
>
> positioning is
>>
>> available (which would let us do 'x pixels from the right').
>
> Done.
>
> http://codereview.chromium.org/6272008/
>