Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 6272004: Make the 'name' property on error prototypes read-only and dont-delete... (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the 'name' property on error prototypes read-only and dont-delete to avoid leaking of error objects to accessor methods when formatting error messages internally. Also, do not call overwritten toString methods on error objects when formatting messages internally. Committed: http://code.google.com/p/v8/source/detail?r=6322

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M src/messages.js View 3 chunks +15 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M test/mjsunit/error-constructors.js View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 11 months ago (2011-01-14 12:40:51 UTC) #1
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-14 12:47:26 UTC) #2
LGTM

http://codereview.chromium.org/6272004/diff/1/test/mjsunit/error-constructors.js
File test/mjsunit/error-constructors.js (right):

http://codereview.chromium.org/6272004/diff/1/test/mjsunit/error-constructors...
test/mjsunit/error-constructors.js:57: delete ReferenceError.prototype.name;
add
assertEquals("ReferenceError", ReferenceError.prototype.name);

just after delete as well?

Powered by Google App Engine
This is Rietveld 408576698