Issue 6272003: Add another didRunInsecureContent method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6272003: Add another didRunInsecureContent method. (Closed)

Created:
9 years, 11 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add another didRunInsecureContent method. In order to better log mixed-scripting issues I want to get the URL into Chrome land. This involves a WebKit change ([1]) but, by making this change first, we can decouple of the two changes. [1] https://bugs.webkit.org/show_bug.cgi?id=52384 BUG=none TEST=compile

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -7 lines)
M	chrome/browser/tab_contents/tab_contents.h	View	1 chunk	+2 lines, -1 line	0 comments
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/common/render_messages_internal.h	View	1 chunk	+3 lines, -2 lines	0 comments
M	chrome/renderer/render_view.h	View	1 chunk	+11 lines, -1 line	1 comment
M	chrome/renderer/render_view.cc	View	1 chunk	+10 lines, -1 line	0 comments
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+9 lines, -1 line	0 comments
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+9 lines, -0 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

9 years, 11 months ago (2011-01-13 22:30:13 UTC) #2

http://codereview.chromium.org/6272003/diff/1/chrome/renderer/render_view.h
File chrome/renderer/render_view.h (right):

http://codereview.chromium.org/6272003/diff/1/chrome/renderer/render_view.h#n...
chrome/renderer/render_view.h:629: const WebKit::WebString& target);
Not WebURL?

Expand Messages | Collapse Messages