Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 6271022: Blacklisted GPU acceleration for Intel 945 on Windows.... (Closed)

Created:
9 years, 11 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Blacklisted GPU acceleration for Intel 945 on Windows. It was associated with a lot of crashes. TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/resources/gpu_blacklist.json View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
9 years, 11 months ago (2011-01-26 01:03:26 UTC) #1
Zhenyao Mo
9 years, 11 months ago (2011-01-26 01:59:03 UTC) #2
LGTM

nit: when you land, please also update the "version" field in the
gpu_blacklist.json file.

On Tue, Jan 25, 2011 at 5:03 PM, <apatrick@chromium.org> wrote:

> Reviewers: Zhenyao Mo,
>
> Description:
> Blacklisted GPU acceleration for Intel 945 on Windows.
>
> It was associated with a lot of crashes.
>
> TEST=try
> BUG=none
>
>
> Please review this at http://codereview.chromium.org/6271022/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/resources/gpu_blacklist.json
>
>
> Index: chrome/browser/resources/gpu_blacklist.json
> ===================================================================
> --- chrome/browser/resources/gpu_blacklist.json (revision 72575)
> +++ chrome/browser/resources/gpu_blacklist.json (working copy)
> @@ -81,6 +81,17 @@
>       "blacklist": [
>         "accelerated_compositing"
>       ]
> +    },
> +    { // Intel Mobile 945 Express Chipset Family
> +      "id": "4",
> +      "os": {
> +        "type": "win"
> +      },
> +      "vendor_id": "0x8086",
> +      "device_id": "0x27AE",
> +      "blacklist": [
> +        "webgl"
> +      ]
>     }
>   ]
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698