Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 6271020: Update V8 and remove known crashes from the reliability tests list.... (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update V8 and remove known crashes from the reliability tests list. The suppresion in the test list is way too general and will mask almost anything V8 related. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/reliability/known_crashes.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 11 months ago (2011-01-25 14:09:49 UTC) #1
Kevin Millikin (Chromium)
9 years, 11 months ago (2011-01-25 14:10:32 UTC) #2
LGTM.


On Tue, Jan 25, 2011 at 3:09 PM, <ager@chromium.org> wrote:

> Reviewers: Kevin Millikin,
>
> Description:
> Update V8 and remove known crashes from the reliability tests list.
>
> The suppresion in the test list is way too general and will mask
> almost anything V8 related.
>
>
> Please review this at http://codereview.chromium.org/6271020/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  M     chrome/test/data/reliability/known_crashes.txt
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 72471)
> +++ DEPS        (working copy)
> @@ -58,7 +58,7 @@
>     (Var("googlecode_url") % "gyp") + "/trunk@874",
>
>   "src/v8":
> -    (Var("googlecode_url") % "v8") + "/trunk@6387",
> +    (Var("googlecode_url") % "v8") + "/trunk@6469",
>
>   "src/native_client":
>     Var("nacl_trunk") + "/src/native_client@" + Var("nacl_revision"),
> Index: chrome/test/data/reliability/known_crashes.txt
> ===================================================================
> --- chrome/test/data/reliability/known_crashes.txt      (revision 72471)
> +++ chrome/test/data/reliability/known_crashes.txt      (working copy)
> @@ -145,6 +145,3 @@
>
>  # 70031
>  SUBSTRING : webcore::shadowdata::`scalar deleting
> destructor___webcore::shadowdata::`scalar deleting
> destructor'___webcore::shadowdata::`scalar deleting
> destructor'___webcore::shadowdata::`scalar deleting destructor'
> -
> -# 70631
> -SUBSTRING : v8::internal::invoke___v8::internal::execution::call
>
>
>

Powered by Google App Engine
This is Rietveld 408576698