Issue 6271019: Fix support for AccessibleObjectFromPoint on page navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6271019: Fix support for AccessibleObjectFromPoint on page navigation (Closed)

Created:
9 years, 11 months ago by Chris Guillory

Modified:
9 years, 7 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When swapping render widget hosts the previous host instance is destroyed after the new host instance is created. This causes an issue because the ViewProp destructor used for saving the host's HWND for accessibility clears the new host's ViewProp since the key (the parent tab contents view host) is identical. Updating the code to explicitly clear the accessibility ViewProp inside Hide() and set it inside Show(). BUG=70657 TEST=Manual. Inspect32. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72524

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_win.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View		3 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

LGTM. Was this affecting anything else or just the linked bug (AccessibleObjectForPoint)?

9 years, 11 months ago (2011-01-25 18:27:56 UTC) #2

Chris Guillory

9 years, 11 months ago (2011-01-25 18:48:29 UTC) #3

> Was this affecting anything else or just the linked bug
> (AccessibleObjectForPoint)?
Yes, it is preventing the IAccessible for the RenderView being returned as a
child of the of the TabContents. We had a test for this but never passed on the
build bot: DISABLED_ContainsRendererAccessibilityTree.

Expand Messages | Collapse Messages