Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/extensions/extension_omnibox_apitest.cc

Issue 6271016: Revert 72381 - Fix size_t in printf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "base/stringprintf.h" 6 #include "base/stringprintf.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/autocomplete/autocomplete.h" 8 #include "chrome/browser/autocomplete/autocomplete.h"
9 #include "chrome/browser/autocomplete/autocomplete_edit.h" 9 #include "chrome/browser/autocomplete/autocomplete_edit.h"
10 #include "chrome/browser/autocomplete/autocomplete_edit_view.h" 10 #include "chrome/browser/autocomplete/autocomplete_edit_view.h"
(...skipping 14 matching lines...) Expand all
25 // http://crbug.com/52929 25 // http://crbug.com/52929
26 #if defined(OS_CHROMEOS) 26 #if defined(OS_CHROMEOS)
27 #define MAYBE_Basic FLAKY_Basic 27 #define MAYBE_Basic FLAKY_Basic
28 #else 28 #else
29 #define MAYBE_Basic Basic 29 #define MAYBE_Basic Basic
30 #endif 30 #endif
31 31
32 namespace { 32 namespace {
33 33
34 string16 AutocompleteResultAsString(const AutocompleteResult& result) { 34 string16 AutocompleteResultAsString(const AutocompleteResult& result) {
35 std::string output(base::StringPrintf("{%z} ", result.size())); 35 std::string output(base::StringPrintf("{%lu} ", result.size()));
36 for (size_t i = 0; i < result.size(); ++i) { 36 for (size_t i = 0; i < result.size(); ++i) {
37 AutocompleteMatch match = result.match_at(i); 37 AutocompleteMatch match = result.match_at(i);
38 std::string provider_name = match.provider->name(); 38 std::string provider_name = match.provider->name();
39 output.append(base::StringPrintf("[\"%s\" by \"%s\"] ", 39 output.append(base::StringPrintf("[\"%s\" by \"%s\"] ",
40 UTF16ToUTF8(match.contents).c_str(), 40 UTF16ToUTF8(match.contents).c_str(),
41 provider_name.c_str())); 41 provider_name.c_str()));
42 } 42 }
43 return UTF8ToUTF16(output); 43 return UTF8ToUTF16(output);
44 } 44 }
45 45
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 } 176 }
177 177
178 { 178 {
179 ResultCatcher catcher; 179 ResultCatcher catcher;
180 autocomplete_controller->Start(ASCIIToUTF16("keyword command"), string16(), 180 autocomplete_controller->Start(ASCIIToUTF16("keyword command"), string16(),
181 true, false, true, false); 181 true, false, true, false);
182 location_bar->AcceptInput(); 182 location_bar->AcceptInput();
183 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 183 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
184 } 184 }
185 } 185 }
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698