PasswordManager fills up text input field with password, or PM crashes chrome tab/window/session

PasswordManager fills up text input field with password, or PM crashes chrome tab/window/session

The password manager was incorrectly down-casting from WebNode to WebInputElement and then upon method invocation, was crashing.  This change adds extra checks to |FindFormInputElements| before down-casting.  Also, when "name" attributes are ambiguous, the code now rejects filling.  This fixes the case where password text can erroneously get filled in the username field.

BUG=29352
TEST=PasswordAutocompleteManagerTest.*, and manual according to bugs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71806

[Ilya Sherman, 2011-01-19 04:58:33]

LGTM

http://codereview.chromium.org/6271007/diff/1/chrome/renderer/password_autoco...
File chrome/renderer/password_autocomplete_manager.cc (right):

http://codereview.chromium.org/6271007/diff/1/chrome/renderer/password_autoco...
chrome/renderer/password_autocomplete_manager.cc:61: // of "name" attribute) so
is considered not found.
nit: Should be "so it is" or something like that

http://codereview.chromium.org/6271007/diff/1/chrome/renderer/password_autoco...
chrome/renderer/password_autocomplete_manager.cc:68: // Note: This assignment
adds a reference to the InputElement.
nit: I think this comment should be moved down to where the element is actually
added to |result|.

[dhollowa, 2011-01-19 16:36:56]

http://codereview.chromium.org/6271007/diff/1/chrome/renderer/password_autoco...
File chrome/renderer/password_autocomplete_manager.cc (right):

http://codereview.chromium.org/6271007/diff/1/chrome/renderer/password_autoco...
chrome/renderer/password_autocomplete_manager.cc:61: // of "name" attribute) so
is considered not found.
On 2011/01/19 04:58:35, Ilya Sherman wrote:
> nit: Should be "so it is" or something like that

Done.

http://codereview.chromium.org/6271007/diff/1/chrome/renderer/password_autoco...
chrome/renderer/password_autocomplete_manager.cc:68: // Note: This assignment
adds a reference to the InputElement.
On 2011/01/19 04:58:35, Ilya Sherman wrote:
> nit: I think this comment should be moved down to where the element is
actually
> added to |result|.

Done.