Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 6271005: Fix clang warning / miscompile (Closed)

Created:
9 years, 11 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Fix clang warning / miscompile BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M breakpad/linux/generate-test-dump.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
Hooray for many repositories!
9 years, 11 months ago (2011-01-18 18:22:48 UTC) #1
Mark Mentovai
LGTM
9 years, 11 months ago (2011-01-24 19:16:21 UTC) #2
Nico
Thanks. Can you merge this into breakpad? On Mon, Jan 24, 2011 at 11:16 AM, ...
9 years, 11 months ago (2011-01-24 19:17:08 UTC) #3
Nico
And by "this" I mean the other CL you just LGTM'd On Mon, Jan 24, ...
9 years, 11 months ago (2011-01-24 19:18:34 UTC) #4
Mark Mentovai
Sure, committed r760.
9 years, 11 months ago (2011-01-24 19:20:35 UTC) #5
Nico
9 years, 11 months ago (2011-01-24 19:24:36 UTC) #6
Thanks.

On Mon, Jan 24, 2011 at 11:20 AM, Mark Mentovai <mark@chromium.org> wrote:
> Sure, committed r760.
>

Powered by Google App Engine
This is Rietveld 408576698