Changed MessageReader so that it doesn't read from the socket if there are

remoting/protocol/message_decoder.h

Index: remoting/protocol/message_decoder.h
diff --git a/remoting/protocol/message_decoder.h b/remoting/protocol/message_decoder.h
index 3e0745f73f9a70a4d017f7797c65d5d7be248601..00873bb71f39f3e1dd4c5b3391edaf767a7ccb23 100644
--- a/remoting/protocol/message_decoder.h
+++ b/remoting/protocol/message_decoder.h
@@ -35,10 +35,10 @@ class MessageDecoder {
   // its bytes are consumed.
   void AddData(scoped_refptr<net::IOBuffer> data, int data_size);
 
-  // Get next message from the stream and puts it in
-  // |message_buffer|. Returns false if there are no complete messages
-  // yet.
-  bool GetNextMessage(CompoundBuffer* message_buffer);
+  // Returns next message from the stream. Onnership of the result is
+  // passed to the caller. Returns NULL if there are no complete
+  // messages yet.

[awong, 2011/01/20 20:06:38]

Should we note somoewhere that each CompoundBuffer is guaranteed to only have 1
message?  Should there be a dcheck and/or unittest to verify this assertion
remains true?

[Alpha Left Google, 2011/01/20 20:54:52]

I don't think there's a simple DCHECK who can do this... :( It really relies how
we craft the compoundbuffer in this class.

[Sergey Ulanov, 2011/01/20 21:55:57]

Extended the comment a bit.
There are unittests for this (message_decoder_unittest,
message_reader_unittest). Also added DCHECK in ProtobufMessageReader.

+  CompoundBuffer* GetNextMessage();
 
  private:
   // Retrieves the read payload size of the current protocol buffer via |size|.