Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 6271: Fixed unsafe code where a GC could occour after a Handle had been deferenced.... (Closed)

Created:
12 years, 2 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fixed unsafe code where a GC could occour after a Handle had been deferenced. instances->set(i, *GetScriptWrapper(script)); GetScriptWrapper can call GC. The failure have only been seen on ARM, where the g++ compiler pulls out the object from the instances handle to a register before calling GetScriptWrapper causing set to be called on an object which may have moved. Marked a test on ARM as no longer flaky, whereas two other fails consistently but that is no longer related to the problem fixed above. BUG=1308895 Committed: http://code.google.com/p/v8/source/detail?r=444

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/runtime.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Søren Thygesen Gjesse
12 years, 2 months ago (2008-10-06 12:58:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698