Issue 6270006: Revert 72685 - [SYNC] Refactor SyncSourceInfo and add support in chrome inval...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6270006: Revert 72685 - [SYNC] Refactor SyncSourceInfo and add support in chrome inval... (Closed)

Created:
9 years, 11 months ago by Nicolas Zea

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 72685 - [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client and syncer thread for passing a datatype-specific payload originating in the invalidation server and directed at the sync frontend server. Also fixes bug with last_sync_time and PostTimeToTypeHistogram, which would get hit when the unit tests were being run. BUG=68572, 69558 TEST=unit Review URL: http://codereview.chromium.org/6182004 TBR=zea@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72687

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -395 lines)			Patch
M	chrome/browser/sync/engine/download_updates_command.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View	4 chunks	+13 lines, -26 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread.h	View	5 chunks	+6 lines, -21 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread.cc	View	12 chunks	+20 lines, -56 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread_unittest.cc	View	8 chunks	+7 lines, -104 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_unittest.cc	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_invalidation_client.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
MM	chrome/browser/sync/notifier/chrome_invalidation_client.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
MM	chrome/browser/sync/notifier/chrome_invalidation_client_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/notifier/server_notifier_thread.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/sync/notifier/server_notifier_thread.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/sessions/sync_session.h	View	2 chunks	+0 lines, -33 lines	0 comments	Download
M	chrome/browser/sync/sessions/sync_session.cc	View	2 chunks	+1 line, -48 lines	0 comments	Download
M	chrome/browser/sync/sessions/sync_session_unittest.cc	View	2 chunks	+0 lines, -59 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/test/sync/engine/syncer_command_test.h	View	2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages