Issue 6270005: Suppress two DrMemory leaks in printing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6270005: Suppress two DrMemory leaks in printing... (Closed)

Created:
9 years, 11 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress two DrMemory leaks in printing BUG=70388, 70389 TBR=glider TEST=DrM/FYI should go green on printing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72140

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 11 months ago (2011-01-21 15:15:39 UTC) #2

LGTM

On Fri, Jan 21, 2011 at 5:18 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress two DrMemory leaks in printing
> BUG=70388,70389
> TBR=glider
> TEST=DrM/FYI should go green on printing
>
> Please review this at http://codereview.chromium.org/6270005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/drmemory/suppressions.txt
>
>
> Index: tools/valgrind/drmemory/suppressions.txt
> ===================================================================
> --- tools/valgrind/drmemory/suppressions.txt    (revision 72126)
> +++ tools/valgrind/drmemory/suppressions.txt    (working copy)
> @@ -432,5 +432,19 @@
>  *!remoting::DecompressorZlib::InitStream
>  *!remoting::DecompressorZlib::Reset
>
> +# http://crbug.com/70388
> +LEAK
> +*!operator new
> +*!NewCallback<PrintingContextTest,enum printing::PrintingContext::Result>
> +*!PrintingContextTest_PrintAll_Test::TestBody
> +
> +# http://crbug.com/70389
> +POSSIBLE LEAK
> +...
> +WINSPOOL.DRV!OpenPrinterW
> +*!PrintDlgExMock
> +*!printing::PrintingContextWin::AskUserForSettings
> +*!PrintingContextTest_PrintAll_Test::TestBody
> +
>  # Empty line at EOF - workaround for
>  # http://code.google.com/p/drmemory/issues/detail?id=41
>
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages