Helper

AppCache: Add a helper method to AppCacheService to test if a request can be handled while offline.

BUG=65547, chromium-os:9559
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72433

[michaeln, 2011-01-21 23:21:08]

Might as well list you as reviewer since you've been looking at
http://code.google.com/p/chromium-os/issues/detail?id=9559 too.

[oshima, 2011-01-23 15:24:18]

Thank you for making this easier. Could you please update the description of
this CL to reflect actual change? It'll help us to find CL later when we need.

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
File webkit/appcache/appcache_service.cc (right):

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.cc:12: #include
"webkit/appcache/appcache_entry.h"
sort includes

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.cc:69: AppCacheService* service, const GURL&
url,
looks like arguments can move to above?

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.cc:86: GURL url_;
DISALLOW_COPY_AND_ASSIGN

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_service.h
File webkit/appcache/appcache_service.h (right):

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.h:61: void CanHandleMainResourceOffline(const
GURL& url,
Comment?

[michaeln, 2011-01-24 20:38:34]

Thnx for looking!

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
File webkit/appcache/appcache_service.cc (right):

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.cc:12: #include
"webkit/appcache/appcache_entry.h"
On 2011/01/23 15:24:18, oshima wrote:
> sort includes

Done.

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.cc:69: AppCacheService* service, const GURL&
url,
On 2011/01/23 15:24:18, oshima wrote:
> looks like arguments can move to above?

The 'callback' param won't fit. In keeping with how the other classes are
defined, I'd like to leave this wrapping as is.

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.cc:86: GURL url_;
On 2011/01/23 15:24:18, oshima wrote:
> DISALLOW_COPY_AND_ASSIGN

Done (here and in other helpers)

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_service.h
File webkit/appcache/appcache_service.h (right):

http://codereview.chromium.org/6269016/diff/1/webkit/appcache/appcache_servic...
webkit/appcache/appcache_service.h:61: void CanHandleMainResourceOffline(const
GURL& url,
On 2011/01/23 15:24:18, oshima wrote:
> Comment?

Done.

[oshima, 2011-01-24 23:36:48]

LGTM

> BUG=65547, chrome-os:9559

chromium-os:9559