Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 6268020: Add new configs to cbuildbot_conf to match master.cfg (Closed)

Created:
9 years, 11 months ago by dgarrett
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add new configs to cbuildbot_conf to match master.cfg Change-Id: I4a28ac0f8e1a90313a9373e213e8a30003d1f8ad BUG=chromium-os:11229 TEST=Unittests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e7b9a4f

Patch Set 1 #

Total comments: 3

Patch Set 2 : Revised configs to have arm and full defaults. #

Patch Set 3 : Fix tegra2_dev-board variant name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -11 lines) Patch
M bin/cbuildbot_config.py View 1 2 6 chunks +62 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgarrett
These changes won't hurt anything, and I think they match the behavior we want to ...
9 years, 11 months ago (2011-01-27 22:37:46 UTC) #1
sosa
Optional comments, LGTM http://codereview.chromium.org/6268020/diff/1/bin/cbuildbot_config.py File bin/cbuildbot_config.py (right): http://codereview.chromium.org/6268020/diff/1/bin/cbuildbot_config.py#newcode145 bin/cbuildbot_config.py:145: Maybe create a default_full ... that ...
9 years, 11 months ago (2011-01-27 23:13:08 UTC) #2
dgarrett
Revised it based on your suggestion, but a bit differently. Hopefully this makes the configs ...
9 years, 11 months ago (2011-01-28 00:18:05 UTC) #3
sosa
LGTM. Thanks for the refactor. Easier to catch breaks between full / arm configs.
9 years, 11 months ago (2011-01-28 18:56:08 UTC) #4
sosa
Actually I think you're missing tegra2_seaboard?
9 years, 11 months ago (2011-01-28 18:57:30 UTC) #5
dgarrett
On 2011/01/28 18:57:30, sosa wrote: > Actually I think you're missing tegra2_seaboard? Should there be ...
9 years, 11 months ago (2011-01-28 22:04:45 UTC) #6
dgarrett
9 years, 11 months ago (2011-01-28 22:04:51 UTC) #7
sosa
9 years, 11 months ago (2011-01-28 22:06:36 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698