Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 6268012: cros_workon: remove logic for handling ~ in workon file (Closed)

Created:
9 years, 11 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
zbehan, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

cros_workon: remove logic for handling ~ in workon file We stopped using ~ in the workon files many months ago. BUG=n0ne TEST=See below. (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic start perf Please run "repo sync" now. INFO : Started working on 'dev-util/perf' for 'x86-generic' (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel dev-util/perf (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic stop perf INFO : Stopped working on 'dev-util/perf' for 'x86-generic' (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel Change-Id: I61babd89073d749111be7257b2e8491f07ca52f2 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=26998d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M cros_workon View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
9 years, 11 months ago (2011-01-24 21:43:41 UTC) #1
anush
9 years, 11 months ago (2011-01-24 21:45:57 UTC) #2
LGTM

On Mon, Jan 24, 2011 at 1:43 PM, <msb@chromium.org> wrote:

> Reviewers: anush, zbehan,
>
> Description:
> cros_workon: remove logic for handling ~ in workon file
>
> We stopped using ~ in the workon files many months ago.
>
> BUG=n0ne
> TEST=See below.
>
> (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board
> x86-generic
> list
> sys-kernel/chromeos-kernel
> (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board
> x86-generic
> start perf
> Please run "repo sync" now.
> INFO   : Started working on 'dev-util/perf' for 'x86-generic'
> (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board
> x86-generic
> list
> sys-kernel/chromeos-kernel
> dev-util/perf
> (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board
> x86-generic
> stop perf
> INFO   : Stopped working on 'dev-util/perf' for 'x86-generic'
> (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board
> x86-generic
> list
> sys-kernel/chromeos-kernel
>
> Change-Id: I61babd89073d749111be7257b2e8491f07ca52f2
>
> Please review this at http://codereview.chromium.org/6268012/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M cros_workon
>
>
> Index: cros_workon
> diff --git a/cros_workon b/cros_workon
> index
>
c48b6431e512c6049badc6aab2c3aaeafd00f070..f12bc7a9e44a3a474b036108a2e9b65a40dfee71
> 100755
> --- a/cros_workon
> +++ b/cros_workon
> @@ -135,7 +135,7 @@ canonicalize_names () {
>
>  # Display ebuilds currently part of the live branch and open for
> development.
>  show_live_ebuilds () {
> -  sed -n 's/^[~=]\(.*\)-9999$/\1/p' "${WORKON_FILE}"
> +  sed -n 's/^=\(.*\)-9999$/\1/p' "${WORKON_FILE}"
>  }
>
>  # Display ebuilds currently part of the live branch and open for
> development
> @@ -144,7 +144,7 @@ show_all_live_ebuilds () {
>   for workon_file in ${WORKON_DIR}/*; do
>     if [ -s "${workon_file}" ]; then
>       echo -e "${V_BOLD_GREEN}$(basename ${workon_file}):${V_VIDOFF}"
> -      sed -n 's/^[~=]\(.*\)-9999$/    \1/p' "${workon_file}"
> +      sed -n 's/^=\(.*\)-9999$/    \1/p' "${workon_file}"
>       echo ""
>     fi
>   done
> @@ -176,7 +176,7 @@ ebuild_to_live () {
>   local atoms_success=""
>
>   for atom in ${atoms}; do
> -    if ! grep -qx "[~=]${atom}-9999" "${WORKON_FILE}" ; then
> +    if ! grep -qx "=${atom}-9999" "${WORKON_FILE}" ; then
>       if sudo bash -c "echo \"=${atom}-9999\" >> \"${WORKON_FILE}\""; then
>         atoms_success="${atoms_success} ${atom}"
>       fi
> @@ -194,8 +194,8 @@ ebuild_to_stable () {
>   local atoms_success=""
>
>   for atom in ${atoms}; do
> -    if grep -qx "[~=]${atom}-9999" "${WORKON_FILE}" ; then
> -      if sudo sed -e "/^[~=]${atom/\//\\/}-9999\$/d" -i "${WORKON_FILE}";
> then
> +    if grep -qx "=${atom}-9999" "${WORKON_FILE}" ; then
> +      if sudo sed -e "/^=${atom/\//\\/}-9999\$/d" -i "${WORKON_FILE}";
> then
>         atoms_success="${atoms_success} ${atom}"
>       fi
>     else
>
>
>

Powered by Google App Engine
This is Rietveld 408576698