Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

Issue 6268005: Removes the link in the omnibox for searching history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc b/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
index 539760afad409a4528fba85c62ea25ef39356bab..be700cbbf3457c9a87f8113c2b647f2cb8aa4b5f 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc
@@ -577,47 +577,6 @@ IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, EnterToSearch) {
EXPECT_STREQ(kSearchSingleCharURL, url.spec().c_str());
}
-// See http://crbug.com/20934: Omnibox keyboard behavior wrong for
-// "See recent pages in history"
-IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, EnterToOpenHistoryPage) {
- ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
-
- ASSERT_NO_FATAL_FAILURE(SetupComponents());
- browser()->FocusLocationBar();
-
- AutocompleteEditView* edit_view = NULL;
- ASSERT_NO_FATAL_FAILURE(GetAutocompleteEditView(&edit_view));
- AutocompletePopupModel* popup_model = edit_view->model()->popup_model();
- ASSERT_TRUE(popup_model);
-
- ASSERT_NO_FATAL_FAILURE(SendKeySequence(kSearchTextKeys));
- ASSERT_NO_FATAL_FAILURE(WaitForAutocompleteControllerDone());
- ASSERT_TRUE(popup_model->IsOpen());
- EXPECT_EQ(0U, popup_model->selected_line());
-
- // Move to the history page item.
- size_t size = popup_model->result().size();
- while (true) {
- if (popup_model->result().match_at(popup_model->selected_line()).type ==
- AutocompleteMatch::OPEN_HISTORY_PAGE)
- break;
- size_t old_selected_line = popup_model->selected_line();
- ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_DOWN, false, false, false));
- ASSERT_EQ(old_selected_line + 1, popup_model->selected_line());
- if (popup_model->selected_line() == size - 1)
- break;
- }
-
- // Make sure the history page item is selected.
- ASSERT_EQ(AutocompleteMatch::OPEN_HISTORY_PAGE,
- popup_model->result().match_at(popup_model->selected_line()).type);
-
- // Open the history page item.
- ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RETURN, false, false, false));
- GURL url = browser()->GetSelectedTabContents()->GetURL();
- EXPECT_STREQ(kHistoryPageURL, url.spec().c_str());
-}
-
IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, EscapeToDefaultMatch) {
ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));

Powered by Google App Engine
This is Rietveld 408576698