Add a link to the safe browsing privacy policies in the option to send malwar...

Add a link to the safe browsing privacy policies in the option to send malware details to Google.
BUG=60831
TEST=relevant unit_tests,browser_tests, go to ianfette.org.

[lzheng, 2011-01-13 17:49:34]

Should we explain the "additional data" at
http://www.google.com/intl/en_us/privacy/browsing.html, or it is mentioned
somewhere else?

http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):

http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:421: GURL
url(kSbPrivacyPolicyUrl);  // Note: this page is not yet localized.
Put this note at where kSbPrivacyPolicyUrl is defined. What's the plan to
localize that page? How to direct chrome to a localized link?

[panayiotis, 2011-01-13 18:56:29]

Yes, we'll explain the "aditional data" in a section in the privacy policy. At
least that's the current plan.

http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):

http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:421: GURL
url(kSbPrivacyPolicyUrl);  // Note: this page is not yet localized.
On 2011/01/13 17:49:35, lzheng wrote:
> Put this note at where kSbPrivacyPolicyUrl is defined. What's the plan to
> localize that page? How to direct chrome to a localized link?

Done. I'll ping Ian on the localization plan. Localized links can be generated
with google_util::AppendGoogleLocaleParam as in line 411.

[ian fette, 2011-01-13 23:37:30]

The SB privacy policy is not localized. For smaller services / APIs, we
sometimes do not localize the privacy policy.

On 2011/01/13 18:56:29, panayiotis wrote:
> Yes, we'll explain the "aditional data" in a section in the privacy policy. At
> least that's the current plan.
> 
>
http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
> File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):
> 
>
http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
> chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:421: GURL
> url(kSbPrivacyPolicyUrl);  // Note: this page is not yet localized.
> On 2011/01/13 17:49:35, lzheng wrote:
> > Put this note at where kSbPrivacyPolicyUrl is defined. What's the plan to
> > localize that page? How to direct chrome to a localized link?
> 
> Done. I'll ping Ian on the localization plan. Localized links can be generated
> with google_util::AppendGoogleLocaleParam as in line 411.

[lzheng, 2011-01-13 23:45:22]

LGTM. 

I assume that you will make sure the page is updated with "additinal data".


On 2011/01/13 23:37:30, ian fette wrote:
> The SB privacy policy is not localized. For smaller services / APIs, we
> sometimes do not localize the privacy policy.
> 
> On 2011/01/13 18:56:29, panayiotis wrote:
> > Yes, we'll explain the "aditional data" in a section in the privacy policy.
At
> > least that's the current plan.
> > 
> >
>
http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
> > File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):
> > 
> >
>
http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
> > chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:421: GURL
> > url(kSbPrivacyPolicyUrl);  // Note: this page is not yet localized.
> > On 2011/01/13 17:49:35, lzheng wrote:
> > > Put this note at where kSbPrivacyPolicyUrl is defined. What's the plan to
> > > localize that page? How to direct chrome to a localized link?
> > 
> > Done. I'll ping Ian on the localization plan. Localized links can be
generated
> > with google_util::AppendGoogleLocaleParam as in line 411.

[panayiotis, 2011-01-14 23:28:38]

Thanks, yes, we'll have the page updated.

On 2011/01/13 23:45:22, lzheng wrote:
> LGTM. 
> 
> I assume that you will make sure the page is updated with "additinal data".
> 
> 
> On 2011/01/13 23:37:30, ian fette wrote:
> > The SB privacy policy is not localized. For smaller services / APIs, we
> > sometimes do not localize the privacy policy.
> > 
> > On 2011/01/13 18:56:29, panayiotis wrote:
> > > Yes, we'll explain the "aditional data" in a section in the privacy
policy.
> At
> > > least that's the current plan.
> > > 
> > >
> >
>
http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
> > > File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/6268001/diff/3001/chrome/browser/safe_browsing...
> > > chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:421: GURL
> > > url(kSbPrivacyPolicyUrl);  // Note: this page is not yet localized.
> > > On 2011/01/13 17:49:35, lzheng wrote:
> > > > Put this note at where kSbPrivacyPolicyUrl is defined. What's the plan
to
> > > > localize that page? How to direct chrome to a localized link?
> > > 
> > > Done. I'll ping Ian on the localization plan. Localized links can be
> generated
> > > with google_util::AppendGoogleLocaleParam as in line 411.