build/util/lastchange.py - Issue 6265031: lastchange: use shell=True on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/util/lastchange.py

Issue 6265031: lastchange: use shell=True on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/util/lastchange.py

diff --git a/build/util/lastchange.py b/build/util/lastchange.py

index 7c34fbea3b41f50014c36858b12c2613d9cefc50..c7200f1e25165494192e35bd6bdeaffc03067175 100755

--- a/build/util/lastchange.py

+++ b/build/util/lastchange.py

@@ -60,7 +60,8 @@ def FetchSVNRevision(directory):

proc = subprocess.Popen(['svn', 'info'],

stdout=subprocess.PIPE,

stderr=subprocess.PIPE,

- cwd=directory)

+ cwd=directory,

+ shell=(sys.platform=='win32'))

except OSError:

# command is apparently either not installed or not executable.

return None

« no previous file with comments | « no previous file | no next file » | no next file with comments »