Issue 6265031: lastchange: use shell=True on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6265031: lastchange: use shell=True on Windows (Closed)

Created:
9 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, chase

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

lastchange: use shell=True on Windows I regressed this by refactoring some code together then splitting it again. Originally it was fixed in r18533. BUG=71016 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72897

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/util/lastchange.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Evan Martin

http://src.chromium.org/viewvc/chrome?view=rev&revision=18533 is the old diff fyi

9 years, 11 months ago (2011-01-27 23:19:17 UTC) #1

chase

9 years, 11 months ago (2011-01-27 23:23:27 UTC) #3

On 2011/01/27 23:21:31, chase wrote:
> lgtm, i'm going to try testing directly on build1-m1

worked locally after patch applied