IndexedDB: Prepare to remove IDBCallbacks::onSuccess() used for null values.

IndexedDB: Prepare to remove IDBCallbacks::onSuccess() used for null values.

The WebKit side code will change to use onSuccess(SerializedScriptValue::nullValue()) instead.

BUG=70221
TEST=no new functionality

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72781

[jorlow, 2011-01-26 18:06:22]

I don't understand why this is needed.  You should be able to just remove
the <void> specialization once the webkit side rolls.

On Wed, Jan 26, 2011 at 9:51 AM, <hans@chromium.org> wrote:

> Reviewers: jorlow, andreip3000,
>
> Description:
> IndexedDB: Prepare to remove IDBCallbacks::onSuccess() used for null
> values.
>
> The WebKit side code will change to use
> onSuccess(SerializedScriptValue::nullValue()) instead.
>
> BUG=70221
> TEST=no new functionality
>
> Please review this at http://codereview.chromium.org/6265027/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/in_process_webkit/indexed_db_callbacks.h
>
>
> Index: chrome/browser/in_process_webkit/indexed_db_callbacks.h
> diff --git a/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> b/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> index
>
23544eda323d6230e501589f2e10ce1572f0b5ee..e5c6b18299a85b2c6afcfbde5d66a1a4b5063a02
> 100644
> --- a/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> +++ b/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> @@ -91,6 +91,13 @@ class IndexedDBCallbacks<WebKit::WebIDBCursor>
>         new IndexedDBMsg_CallbacksSuccessIDBCursor(response_id(),
> object_id));
>   }
>
> +  virtual void onSuccess(const WebKit::WebSerializedScriptValue& value) {
> +    dispatcher_host()->Send(
> +        new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
> +            response_id(), SerializedScriptValue(value)));
> +  }
> +
> +  // TODO(hans): Remove when WebKit rolls.
>   virtual void onSuccess() {
>     dispatcher_host()->Send(new IndexedDBMsg_CallbacksSuccessNull(
>         response_id()));
> @@ -150,6 +157,13 @@ class IndexedDBCallbacks<void> : public
> IndexedDBCallbacksBase {
>       IndexedDBDispatcherHost* dispatcher_host, int32 response_id)
>       : IndexedDBCallbacksBase(dispatcher_host, response_id) { }
>
> +  virtual void onSuccess(const WebKit::WebSerializedScriptValue& value) {
> +    dispatcher_host()->Send(
> +        new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
> +            response_id(), SerializedScriptValue(value)));
> +  }
> +
> +  // TODO(hans): Remove when WebKit rolls.
>   virtual void onSuccess() {
>     dispatcher_host()->Send(
>         new IndexedDBMsg_CallbacksSuccessNull(response_id()));
>
>
>

[hans, 2011-01-26 18:48:40]

On Wed, Jan 26, 2011 at 6:00 PM, Jeremy Orlow <jorlow@chromium.org> wrote:
> I don't understand why this is needed.  You should be able to just remove
> the <void> specialization once the webkit side rolls.

That was my first approach.. but when I land the WebKit side, the
<void> and <WebIDBCursor> specializations are still hit, but they
don't overload onSuccess(WebSerializedScriptValue), and so I hit
asserts for getting the default implementations.

>
> On Wed, Jan 26, 2011 at 9:51 AM, <hans@chromium.org> wrote:
>>
>> Reviewers: jorlow, andreip3000,
>>
>> Description:
>> IndexedDB: Prepare to remove IDBCallbacks::onSuccess() used for null
>> values.
>>
>> The WebKit side code will change to use
>> onSuccess(SerializedScriptValue::nullValue()) instead.
>>
>> BUG=70221
>> TEST=no new functionality
>>
>> Please review this at http://codereview.chromium.org/6265027/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M chrome/browser/in_process_webkit/indexed_db_callbacks.h
>>
>>
>> Index: chrome/browser/in_process_webkit/indexed_db_callbacks.h
>> diff --git a/chrome/browser/in_process_webkit/indexed_db_callbacks.h
>> b/chrome/browser/in_process_webkit/indexed_db_callbacks.h
>> index
>>
23544eda323d6230e501589f2e10ce1572f0b5ee..e5c6b18299a85b2c6afcfbde5d66a1a4b5063a02
>> 100644
>> --- a/chrome/browser/in_process_webkit/indexed_db_callbacks.h
>> +++ b/chrome/browser/in_process_webkit/indexed_db_callbacks.h
>> @@ -91,6 +91,13 @@ class IndexedDBCallbacks<WebKit::WebIDBCursor>
>>         new IndexedDBMsg_CallbacksSuccessIDBCursor(response_id(),
>> object_id));
>>   }
>>
>> +  virtual void onSuccess(const WebKit::WebSerializedScriptValue& value) {
>> +    dispatcher_host()->Send(
>> +        new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
>> +            response_id(), SerializedScriptValue(value)));
>> +  }
>> +
>> +  // TODO(hans): Remove when WebKit rolls.
>>   virtual void onSuccess() {
>>     dispatcher_host()->Send(new IndexedDBMsg_CallbacksSuccessNull(
>>         response_id()));
>> @@ -150,6 +157,13 @@ class IndexedDBCallbacks<void> : public
>> IndexedDBCallbacksBase {
>>       IndexedDBDispatcherHost* dispatcher_host, int32 response_id)
>>       : IndexedDBCallbacksBase(dispatcher_host, response_id) { }
>>
>> +  virtual void onSuccess(const WebKit::WebSerializedScriptValue& value) {
>> +    dispatcher_host()->Send(
>> +        new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
>> +            response_id(), SerializedScriptValue(value)));
>> +  }
>> +
>> +  // TODO(hans): Remove when WebKit rolls.
>>   virtual void onSuccess() {
>>     dispatcher_host()->Send(
>>         new IndexedDBMsg_CallbacksSuccessNull(response_id()));
>>
>>
>
>

[jorlow, 2011-01-26 18:54:18]

ohhh...i see

LGTM

On Wed, Jan 26, 2011 at 10:48 AM, Hans Wennborg <hans@chromium.org> wrote:

> On Wed, Jan 26, 2011 at 6:00 PM, Jeremy Orlow <jorlow@chromium.org> wrote:
> > I don't understand why this is needed.  You should be able to just remove
> > the <void> specialization once the webkit side rolls.
>
> That was my first approach.. but when I land the WebKit side, the
> <void> and <WebIDBCursor> specializations are still hit, but they
> don't overload onSuccess(WebSerializedScriptValue), and so I hit
> asserts for getting the default implementations.
>
> >
> > On Wed, Jan 26, 2011 at 9:51 AM, <hans@chromium.org> wrote:
> >>
> >> Reviewers: jorlow, andreip3000,
> >>
> >> Description:
> >> IndexedDB: Prepare to remove IDBCallbacks::onSuccess() used for null
> >> values.
> >>
> >> The WebKit side code will change to use
> >> onSuccess(SerializedScriptValue::nullValue()) instead.
> >>
> >> BUG=70221
> >> TEST=no new functionality
> >>
> >> Please review this at http://codereview.chromium.org/6265027/
> >>
> >> SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >>
> >> Affected files:
> >>  M chrome/browser/in_process_webkit/indexed_db_callbacks.h
> >>
> >>
> >> Index: chrome/browser/in_process_webkit/indexed_db_callbacks.h
> >> diff --git a/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> >> b/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> >> index
> >>
>
23544eda323d6230e501589f2e10ce1572f0b5ee..e5c6b18299a85b2c6afcfbde5d66a1a4b5063a02
> >> 100644
> >> --- a/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> >> +++ b/chrome/browser/in_process_webkit/indexed_db_callbacks.h
> >> @@ -91,6 +91,13 @@ class IndexedDBCallbacks<WebKit::WebIDBCursor>
> >>         new IndexedDBMsg_CallbacksSuccessIDBCursor(response_id(),
> >> object_id));
> >>   }
> >>
> >> +  virtual void onSuccess(const WebKit::WebSerializedScriptValue& value)
> {
> >> +    dispatcher_host()->Send(
> >> +        new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
> >> +            response_id(), SerializedScriptValue(value)));
> >> +  }
> >> +
> >> +  // TODO(hans): Remove when WebKit rolls.
> >>   virtual void onSuccess() {
> >>     dispatcher_host()->Send(new IndexedDBMsg_CallbacksSuccessNull(
> >>         response_id()));
> >> @@ -150,6 +157,13 @@ class IndexedDBCallbacks<void> : public
> >> IndexedDBCallbacksBase {
> >>       IndexedDBDispatcherHost* dispatcher_host, int32 response_id)
> >>       : IndexedDBCallbacksBase(dispatcher_host, response_id) { }
> >>
> >> +  virtual void onSuccess(const WebKit::WebSerializedScriptValue& value)
> {
> >> +    dispatcher_host()->Send(
> >> +        new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
> >> +            response_id(), SerializedScriptValue(value)));
> >> +  }
> >> +
> >> +  // TODO(hans): Remove when WebKit rolls.
> >>   virtual void onSuccess() {
> >>     dispatcher_host()->Send(
> >>         new IndexedDBMsg_CallbacksSuccessNull(response_id()));
> >>
> >>
> >
> >
>