Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 6265020: Zero-fill tab drag icon pixel buffer. (Closed)

Created:
9 years, 11 months ago by eugenis
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Zero-fill tab drag icon pixel buffer. BUG=70379 TEST=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evgeniy Stepanov
9 years, 11 months ago (2011-01-21 12:54:08 UTC) #1
Elliot Glaysher
http://codereview.chromium.org/6265020/diff/1/chrome/browser/ui/gtk/tabs/tab_gtk.cc File chrome/browser/ui/gtk/tabs/tab_gtk.cc (right): http://codereview.chromium.org/6265020/diff/1/chrome/browser/ui/gtk/tabs/tab_gtk.cc#newcode254 chrome/browser/ui/gtk/tabs/tab_gtk.cc:254: memset(pixels, 0, 4); Try 'gdk_pixbuf_fill(pixbuf, 0);' instead. This should ...
9 years, 11 months ago (2011-01-21 21:33:06 UTC) #2
Evgeniy Stepanov
On 2011/01/21 21:33:06, Elliot Glaysher wrote: > http://codereview.chromium.org/6265020/diff/1/chrome/browser/ui/gtk/tabs/tab_gtk.cc > File chrome/browser/ui/gtk/tabs/tab_gtk.cc (right): > > http://codereview.chromium.org/6265020/diff/1/chrome/browser/ui/gtk/tabs/tab_gtk.cc#newcode254 ...
9 years, 11 months ago (2011-01-24 09:37:24 UTC) #3
Elliot Glaysher
9 years, 11 months ago (2011-01-24 18:25:09 UTC) #4
On 2011/01/24 09:37:24, Evgeniy Stepanov wrote:
> On 2011/01/21 21:33:06, Elliot Glaysher wrote:
> >
>
http://codereview.chromium.org/6265020/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> > File chrome/browser/ui/gtk/tabs/tab_gtk.cc (right):
> > 
> >
>
http://codereview.chromium.org/6265020/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> > chrome/browser/ui/gtk/tabs/tab_gtk.cc:254: memset(pixels, 0, 4);
> > Try 'gdk_pixbuf_fill(pixbuf, 0);' instead. This should perform the fill
> without
> > violating the encapsulation.
> 
> Done.

LGTM

Powered by Google App Engine
This is Rietveld 408576698