Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 6265015: [Mac] Merge single-function file about_ipc_dialog.{h,mm} into about_ipc_bridge.{h,mm}. (Closed)

Created:
9 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[Mac] Merge single-function file about_ipc_dialog.{h,mm} and about_ipc_bridge.{h,mm}. BUG=none TEST=everything works as before (note, about:ipc only works in Debug builds) R=jrg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72035

Patch Set 1 #

Patch Set 2 : bridge -> dialog #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M chrome/browser/ui/cocoa/about_ipc_bridge.h View 1 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_bridge.mm View 1 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/about_ipc_dialog.h View 1 2 chunks +26 lines, -5 lines 0 comments Download
D chrome/browser/ui/cocoa/about_ipc_dialog.mm View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
9 years, 11 months ago (2011-01-20 22:01:37 UTC) #1
John Grabowski
If I had to choose a single name I would have placed everything in about_ipc_dialog.mm ...
9 years, 11 months ago (2011-01-20 22:15:00 UTC) #2
Robert Sesek
9 years, 11 months ago (2011-01-20 22:31:49 UTC) #3
On 2011/01/20 22:15:00, John Grabowski wrote:
> If I had to choose a single name I would have placed everything in
> about_ipc_dialog.mm instead of about_ipc_bridge.mm.  But I suppose it doesn't
> matter much.
> 
> LGTM

I think so too. Done!

Powered by Google App Engine
This is Rietveld 408576698