Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 6265010: DOMUI settings: move/rename the language options panel so that it can be use... (Closed)

Created:
9 years, 11 months ago by csilv
Modified:
9 years, 7 months ago
Reviewers:
satorux1, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

DOMUI settings: move/rename the language options panel so that it can be used cross-platform. This is just a move CL, code changes will come in a followup. Moving the files will make the next code review easier. BUG=56415 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71833

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1996 lines) Patch
D chrome/browser/chromeos/dom_ui/language_options_handler.h View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/chromeos/dom_ui/language_options_handler.cc View 1 chunk +0 lines, -315 lines 0 comments Download
D chrome/browser/chromeos/dom_ui/language_options_handler_unittest.cc View 1 chunk +0 lines, -173 lines 0 comments Download
A + chrome/browser/dom_ui/options/language_options_handler.h View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
A + chrome/browser/dom_ui/options/language_options_handler.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
A + chrome/browser/dom_ui/options/language_options_handler_unittest.cc View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/resources/options/chromeos_language_add_language_overlay.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/resources/options/chromeos_language_add_language_overlay.js View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/resources/options/chromeos_language_list.js View 1 chunk +0 lines, -351 lines 0 comments Download
D chrome/browser/resources/options/chromeos_language_options.css View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/resources/options/chromeos_language_options.html View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/resources/options/chromeos_language_options.js View 1 chunk +0 lines, -761 lines 0 comments Download
A + chrome/browser/resources/options/language_add_language_overlay.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/language_add_language_overlay.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/language_list.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/language_options.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/language_options.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/language_options.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/options/options.html View 8 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
csilv
+jhawkins, +satorux for review
9 years, 11 months ago (2011-01-19 03:02:32 UTC) #1
James Hawkins
LGTM
9 years, 11 months ago (2011-01-19 03:03:56 UTC) #2
csilv
9 years, 11 months ago (2011-01-19 18:31:23 UTC) #3
Added fixed gypi files to this changelist, this should allow the CrOS and Linux
Views trybots to go green.

Powered by Google App Engine
This is Rietveld 408576698