Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
6265009:
Bundle audio spatialization resources for use by the web audio API... (Closed)
|
Created:
9 years, 11 months ago by Chris Rogers Modified:
9 years, 7 months ago CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionBundle audio spatialization resources for use by the web audio API
BUG=none
TEST=none
(I tested locally on Mac OS X against all of my web audio API demos)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72259
Patch Set 1 #
Total comments: 5
Patch Set 2 : '' #
Messages
Total messages: 16 (0 generated)
This corresponds to WebKit patch: Add WebKitAudio.grd for chromium bundled audio spatialization resources https://bugs.webkit.org/show_bug.cgi?id=52651
I'd like to defer this code review (and the review of the WebKit patch) to Tony Chang. He knows the resources system the best.
Most of the gyp changes will go away if you put the resources in WebKit.grd as I mentioned on the webkit bug. http://codereview.chromium.org/6265009/diff/1/webkit/glue/webkitclient_impl.cc File webkit/glue/webkitclient_impl.cc (right): http://codereview.chromium.org/6265009/diff/1/webkit/glue/webkitclient_impl.c... webkit/glue/webkitclient_impl.cc:306: sscanf(name, "IRC_Composite_C_R0195_T%3d_P%3d", &azimuth, &elevation); Nit: Maybe you could also check the return value of sscanf to make sure both ints were parsed? http://codereview.chromium.org/6265009/diff/1/webkit/glue/webkitclient_impl.c... webkit/glue/webkitclient_impl.cc:316: bool is_elevation_index_good = 0 <= elevation_index < 10; I don't think this does what you think this does. If only this were python . . . http://codereview.chromium.org/6265009/diff/1/webkit/glue/webkitclient_impl.c... webkit/glue/webkitclient_impl.cc:320: bool is_azimuth_index_good = 0 <= azimuth_index < 24; Same as above, I think you need to split this out into 0 <= azimuth_index && azimuth_index < 24. I think the gcc we use on Linux will complain about this. http://codereview.chromium.org/6265009/diff/1/webkit/glue/webkitclient_impl.c... webkit/glue/webkitclient_impl.cc:325: bool is_resource_index_good = 0 <= resource_index < kNumberOfAudioResources; Same error as above. http://codereview.chromium.org/6265009/diff/1/webkit/glue/webkitclient_impl.c... webkit/glue/webkitclient_impl.cc:394: if (!strncmp(name, "IRC_Composite", 13)) { There's a StartsWithASCII() function in base/string_util.h you could use here.
Tony, I think I've addressed all of your comments. First of all, many of the .gyp files are no longer necessary since I'm now adding the files to WebKit.grd instead of creating a new .grd. * I'm now checking the return from sscanf() to verify it correctly parses * I've fixed the incorrect integer comparisons. That was a silly mistake I made in copying from some comments I had where I used that style... * I'm now using the StartsWithASCII() function as you recommend.
LGTM! You'll have to wait for the upstream WebKit.grd change to go in, right?
Thanks Tony! Yes, I'll definitely wait until the WebKit side lands and DEPS roll before landing this...
Had to revert this change because we got: http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui...
Ok, I'm surprised that this patch could possibly cause the tests to fail. We'll have to try re-landing later when things settle down a bit... On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: > Had to revert this change because we got: > > > http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 > > http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... > > http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... > > http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... > > http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... > > http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... > > > http://codereview.chromium.org/6265009/ >
I am surprised too because the try bot looked fine. It could be the combination of things. I saw enabled some #define upstream so maybe it's to do with that. - Ryosuke On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com> wrote: > Ok, I'm surprised that this patch could possibly cause the tests to fail. > We'll have to try re-landing later when things settle down a bit... > > > On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: > >> Had to revert this change because we got: >> >> >> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >> >> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >> >> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >> >> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >> >> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >> >> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >> >> >> http://codereview.chromium.org/6265009/ >> > > -- Ryosuke Niwa Software Engineer / Chrome WebKit Google Inc
hmmm, I don't think the #defines should matter. If the tree settles down, then I can try again later. On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: > I am surprised too because the try bot looked fine. It could be the > combination of things. I saw enabled some #define upstream so maybe it's to > do with that. > > - Ryosuke > > > On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com> wrote: > >> Ok, I'm surprised that this patch could possibly cause the tests to fail. >> We'll have to try re-landing later when things settle down a bit... >> >> >> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >> >>> Had to revert this change because we got: >>> >>> >>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>> >>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>> >>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>> >>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>> >>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>> >>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>> >>> >>> http://codereview.chromium.org/6265009/ >>> >> >> > > > -- > Ryosuke Niwa > Software Engineer / Chrome WebKit > Google Inc > > >
I'm truly lost. It seems like even after reverting your change, the tree is still hosed :( What am I supposed to do in this case? - Ryosuke On Fri, Jan 21, 2011 at 8:54 PM, Chris Rogers <crogers@google.com> wrote: > hmmm, I don't think the #defines should matter. If the tree settles down, > then I can try again later. > > > On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: > >> I am surprised too because the try bot looked fine. It could be the >> combination of things. I saw enabled some #define upstream so maybe it's to >> do with that. >> >> - Ryosuke >> >> >> On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com> wrote: >> >>> Ok, I'm surprised that this patch could possibly cause the tests to fail. >>> We'll have to try re-landing later when things settle down a bit... >>> >>> >>> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >>> >>>> Had to revert this change because we got: >>>> >>>> >>>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>>> >>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>>> >>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>>> >>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>>> >>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>>> >>>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>>> >>>> >>>> http://codereview.chromium.org/6265009/ >>>> >>> >>> >> >> >> -- >> Ryosuke Niwa >> Software Engineer / Chrome WebKit >> Google Inc >> >> >> > -- Ryosuke Niwa Software Engineer / Chrome WebKit Google Inc
Maybe try rolling back WebKit DEPS? On Fri, Jan 21, 2011 at 8:55 PM, Ryosuke Niwa <rniwa@google.com> wrote: > I'm truly lost. It seems like even after reverting your change, the tree > is still hosed :( What am I supposed to do in this case? > > - Ryosuke > > > On Fri, Jan 21, 2011 at 8:54 PM, Chris Rogers <crogers@google.com> wrote: > >> hmmm, I don't think the #defines should matter. If the tree settles down, >> then I can try again later. >> >> >> On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: >> >>> I am surprised too because the try bot looked fine. It could be the >>> combination of things. I saw enabled some #define upstream so maybe it's to >>> do with that. >>> >>> - Ryosuke >>> >>> >>> On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com>wrote: >>> >>>> Ok, I'm surprised that this patch could possibly cause the tests to >>>> fail. We'll have to try re-landing later when things settle down a bit... >>>> >>>> >>>> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >>>> >>>>> Had to revert this change because we got: >>>>> >>>>> >>>>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>>>> >>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>>>> >>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>>>> >>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>>>> >>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>>>> >>>>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>>>> >>>>> >>>>> http://codereview.chromium.org/6265009/ >>>>> >>>> >>>> >>> >>> >>> -- >>> Ryosuke Niwa >>> Software Engineer / Chrome WebKit >>> Google Inc >>> >>> >>> >> > > > -- > Ryosuke Niwa > Software Engineer / Chrome WebKit > Google Inc > > >
Ok, I'll roll out 72260-72261. - Ryosuke On Fri, Jan 21, 2011 at 8:59 PM, Chris Rogers <crogers@google.com> wrote: > Maybe try rolling back WebKit DEPS? > > > On Fri, Jan 21, 2011 at 8:55 PM, Ryosuke Niwa <rniwa@google.com> wrote: > >> I'm truly lost. It seems like even after reverting your change, the tree >> is still hosed :( What am I supposed to do in this case? >> >> - Ryosuke >> >> >> On Fri, Jan 21, 2011 at 8:54 PM, Chris Rogers <crogers@google.com> wrote: >> >>> hmmm, I don't think the #defines should matter. If the tree settles >>> down, then I can try again later. >>> >>> >>> On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: >>> >>>> I am surprised too because the try bot looked fine. It could be the >>>> combination of things. I saw enabled some #define upstream so maybe it's to >>>> do with that. >>>> >>>> - Ryosuke >>>> >>>> >>>> On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com>wrote: >>>> >>>>> Ok, I'm surprised that this patch could possibly cause the tests to >>>>> fail. We'll have to try re-landing later when things settle down a bit... >>>>> >>>>> >>>>> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >>>>> >>>>>> Had to revert this change because we got: >>>>>> >>>>>> >>>>>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>>>>> >>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>>>>> >>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>>>>> >>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>>>>> >>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>>>>> >>>>>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>>>>> >>>>>> >>>>>> http://codereview.chromium.org/6265009/ >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Ryosuke Niwa >>>> Software Engineer / Chrome WebKit >>>> Google Inc >>>> >>>> >>>> >>> >> >> >> -- >> Ryosuke Niwa >> Software Engineer / Chrome WebKit >> Google Inc >> >> >> > -- Ryosuke Niwa Software Engineer / Chrome WebKit Google Inc
I rolled out 72260 (WebKit roll) but layout tests were kept crashing on Windows so I also rolled out 72261. - Ryosuke On Fri, Jan 21, 2011 at 9:04 PM, Ryosuke Niwa <rniwa@google.com> wrote: > Ok, I'll roll out 72260-72261. > > - Ryosuke > > > On Fri, Jan 21, 2011 at 8:59 PM, Chris Rogers <crogers@google.com> wrote: > >> Maybe try rolling back WebKit DEPS? >> >> >> On Fri, Jan 21, 2011 at 8:55 PM, Ryosuke Niwa <rniwa@google.com> wrote: >> >>> I'm truly lost. It seems like even after reverting your change, the tree >>> is still hosed :( What am I supposed to do in this case? >>> >>> - Ryosuke >>> >>> >>> On Fri, Jan 21, 2011 at 8:54 PM, Chris Rogers <crogers@google.com>wrote: >>> >>>> hmmm, I don't think the #defines should matter. If the tree settles >>>> down, then I can try again later. >>>> >>>> >>>> On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: >>>> >>>>> I am surprised too because the try bot looked fine. It could be the >>>>> combination of things. I saw enabled some #define upstream so maybe it's to >>>>> do with that. >>>>> >>>>> - Ryosuke >>>>> >>>>> >>>>> On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com>wrote: >>>>> >>>>>> Ok, I'm surprised that this patch could possibly cause the tests to >>>>>> fail. We'll have to try re-landing later when things settle down a bit... >>>>>> >>>>>> >>>>>> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >>>>>> >>>>>>> Had to revert this change because we got: >>>>>>> >>>>>>> >>>>>>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>>>>>> >>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>>>>>> >>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>>>>>> >>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>>>>>> >>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>>>>>> >>>>>>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>>>>>> >>>>>>> >>>>>>> http://codereview.chromium.org/6265009/ >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Ryosuke Niwa >>>>> Software Engineer / Chrome WebKit >>>>> Google Inc >>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> Ryosuke Niwa >>> Software Engineer / Chrome WebKit >>> Google Inc >>> >>> >>> >> > > > -- > Ryosuke Niwa > Software Engineer / Chrome WebKit > Google Inc > > > -- Ryosuke Niwa Software Engineer / Chrome WebKit Google Inc
Ok, that patch explicitly passed the win try-bot, but I guess we'll see what happens... Have you considered: http://src.chromium.org/viewvc/chrome?view=rev&revision=72255 On Fri, Jan 21, 2011 at 9:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: > I rolled out 72260 (WebKit roll) but layout tests were kept crashing on > Windows so I also rolled out 72261. > > - Ryosuke > > On Fri, Jan 21, 2011 at 9:04 PM, Ryosuke Niwa <rniwa@google.com> wrote: > >> Ok, I'll roll out 72260-72261. >> >> - Ryosuke >> >> >> On Fri, Jan 21, 2011 at 8:59 PM, Chris Rogers <crogers@google.com> wrote: >> >>> Maybe try rolling back WebKit DEPS? >>> >>> >>> On Fri, Jan 21, 2011 at 8:55 PM, Ryosuke Niwa <rniwa@google.com> wrote: >>> >>>> I'm truly lost. It seems like even after reverting your change, the >>>> tree is still hosed :( What am I supposed to do in this case? >>>> >>>> - Ryosuke >>>> >>>> >>>> On Fri, Jan 21, 2011 at 8:54 PM, Chris Rogers <crogers@google.com>wrote: >>>> >>>>> hmmm, I don't think the #defines should matter. If the tree settles >>>>> down, then I can try again later. >>>>> >>>>> >>>>> On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com>wrote: >>>>> >>>>>> I am surprised too because the try bot looked fine. It could be the >>>>>> combination of things. I saw enabled some #define upstream so maybe it's to >>>>>> do with that. >>>>>> >>>>>> - Ryosuke >>>>>> >>>>>> >>>>>> On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com>wrote: >>>>>> >>>>>>> Ok, I'm surprised that this patch could possibly cause the tests to >>>>>>> fail. We'll have to try re-landing later when things settle down a bit... >>>>>>> >>>>>>> >>>>>>> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >>>>>>> >>>>>>>> Had to revert this change because we got: >>>>>>>> >>>>>>>> >>>>>>>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>>>>>>> >>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>>>>>>> >>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>>>>>>> >>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>>>>>>> >>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>>>>>>> >>>>>>>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>>>>>>> >>>>>>>> >>>>>>>> http://codereview.chromium.org/6265009/ >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Ryosuke Niwa >>>>>> Software Engineer / Chrome WebKit >>>>>> Google Inc >>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Ryosuke Niwa >>>> Software Engineer / Chrome WebKit >>>> Google Inc >>>> >>>> >>>> >>> >> >> >> -- >> Ryosuke Niwa >> Software Engineer / Chrome WebKit >> Google Inc >> >> >> > > > -- > Ryosuke Niwa > Software Engineer / Chrome WebKit > Google Inc > > >
I have also reverted 72225 but that seems to be a good candidate as well. I'll wait until we get next cycle and might revert that one as well if necessary. - Ryosuke On Fri, Jan 21, 2011 at 10:04 PM, Chris Rogers <crogers@google.com> wrote: > Ok, that patch explicitly passed the win try-bot, but I guess we'll see > what happens... > > Have you considered: > http://src.chromium.org/viewvc/chrome?view=rev&revision=72255 > > On Fri, Jan 21, 2011 at 9:49 PM, Ryosuke Niwa <rniwa@google.com> wrote: > >> I rolled out 72260 (WebKit roll) but layout tests were kept crashing on >> Windows so I also rolled out 72261. >> >> - Ryosuke >> >> On Fri, Jan 21, 2011 at 9:04 PM, Ryosuke Niwa <rniwa@google.com> wrote: >> >>> Ok, I'll roll out 72260-72261. >>> >>> - Ryosuke >>> >>> >>> On Fri, Jan 21, 2011 at 8:59 PM, Chris Rogers <crogers@google.com>wrote: >>> >>>> Maybe try rolling back WebKit DEPS? >>>> >>>> >>>> On Fri, Jan 21, 2011 at 8:55 PM, Ryosuke Niwa <rniwa@google.com> wrote: >>>> >>>>> I'm truly lost. It seems like even after reverting your change, the >>>>> tree is still hosed :( What am I supposed to do in this case? >>>>> >>>>> - Ryosuke >>>>> >>>>> >>>>> On Fri, Jan 21, 2011 at 8:54 PM, Chris Rogers <crogers@google.com>wrote: >>>>> >>>>>> hmmm, I don't think the #defines should matter. If the tree settles >>>>>> down, then I can try again later. >>>>>> >>>>>> >>>>>> On Fri, Jan 21, 2011 at 8:49 PM, Ryosuke Niwa <rniwa@google.com>wrote: >>>>>> >>>>>>> I am surprised too because the try bot looked fine. It could be the >>>>>>> combination of things. I saw enabled some #define upstream so maybe it's to >>>>>>> do with that. >>>>>>> >>>>>>> - Ryosuke >>>>>>> >>>>>>> >>>>>>> On Fri, Jan 21, 2011 at 8:40 PM, Chris Rogers <crogers@google.com>wrote: >>>>>>> >>>>>>>> Ok, I'm surprised that this patch could possibly cause the tests to >>>>>>>> fail. We'll have to try re-landing later when things settle down a bit... >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Jan 21, 2011 at 8:08 PM, <rniwa@chromium.org> wrote: >>>>>>>> >>>>>>>>> Had to revert this change because we got: >>>>>>>>> >>>>>>>>> >>>>>>>>> http://build.chromium.org/p/chromium/builders/XP%20Tests%20(dbg)(4)/builds/2205 >>>>>>>>> >>>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(1)/builds... >>>>>>>>> >>>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(2)/builds... >>>>>>>>> >>>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(3)/builds... >>>>>>>>> >>>>>>>>> http://build.chromium.org/p/chromium/builders/Vista%20Tests%20(dbg)(4)/builds... >>>>>>>>> >>>>>>>>> http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20(dbg)/bui... >>>>>>>>> >>>>>>>>> >>>>>>>>> http://codereview.chromium.org/6265009/ >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Ryosuke Niwa >>>>>>> Software Engineer / Chrome WebKit >>>>>>> Google Inc >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Ryosuke Niwa >>>>> Software Engineer / Chrome WebKit >>>>> Google Inc >>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> Ryosuke Niwa >>> Software Engineer / Chrome WebKit >>> Google Inc >>> >>> >>> >> >> >> -- >> Ryosuke Niwa >> Software Engineer / Chrome WebKit >> Google Inc >> >> >> > -- Ryosuke Niwa Software Engineer / Chrome WebKit Google Inc |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
