Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 6265001: AU: Add support for signing of update payloads after they're generated. (Closed)

Created:
9 years, 11 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Add support for signing of update payloads after they're generated. The change adds 2 methods -- one that takes an unsigned payload and a raw signature size and returns the hash that needs to be signed, and another one that takes an unsigned payload and a raw signature and generates the signed payload. BUG=chromium-os:10872 TEST=unit tests Change-Id: I65bbe72a1ec67e603e78508c33893695b7de0e6a Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9574f7e

Patch Set 1 #

Patch Set 2 : docstrings #

Patch Set 3 : docstrings #

Total comments: 2

Patch Set 4 : rename function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -76 lines) Patch
M delta_diff_generator.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M delta_diff_generator.cc View 2 chunks +22 lines, -16 lines 0 comments Download
M delta_performer.h View 1 2 chunks +17 lines, -0 lines 0 comments Download
M delta_performer.cc View 1 2 chunks +42 lines, -25 lines 0 comments Download
M delta_performer_unittest.cc View 3 chunks +39 lines, -6 lines 0 comments Download
M payload_signer.h View 1 3 chunks +32 lines, -4 lines 0 comments Download
M payload_signer.cc View 1 2 3 5 chunks +132 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
petkov
Here's the basic functionality for signing of generated payloads. Note that this CL doesn't include ...
9 years, 11 months ago (2011-01-13 01:10:13 UTC) #1
adlr
LGTM w/ nit. thanks! http://codereview.chromium.org/6265001/diff/3001/payload_signer.cc File payload_signer.cc (right): http://codereview.chromium.org/6265001/diff/3001/payload_signer.cc#newcode28 payload_signer.cc:28: bool SerializeSignature(const vector<char> signature, this ...
9 years, 11 months ago (2011-01-13 02:27:29 UTC) #2
petkov
9 years, 11 months ago (2011-01-13 18:47:14 UTC) #3
Thanks. Pushing...

http://codereview.chromium.org/6265001/diff/3001/payload_signer.cc
File payload_signer.cc (right):

http://codereview.chromium.org/6265001/diff/3001/payload_signer.cc#newcode28
payload_signer.cc:28: bool SerializeSignature(const vector<char> signature,
On 2011/01/13 02:27:29, adlr wrote:
> this function name w/ the args is a bit confusing. Maybe call it
> "ProtobufizeRawSignature()"?

Done. Renamed to ConvertSignatureToProtobufBlob.

Powered by Google App Engine
This is Rietveld 408576698