Issue 6264015: Avoid closing the speech input UI bubble twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6264015: Avoid closing the speech input UI bubble twice. (Closed)

Created:
9 years, 11 months ago by Leandro Graciá Gil

Modified:
9 years, 7 months ago

Reviewers:
Satish

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Avoid closing speech input UI bubble twice. Some Mac OS Leopard versions were affected by a bug caused by trying to close a speech UI bubble that was being already closed. It has been checked in all platforms that the bubble is closed before calling the focus lose event, making it unnecesary to close it again. BUG=70251 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72506

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/speech/speech_input_bubble_controller.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Leandro Graciá Gil

I'm still pending the final verifications on the Windows build. I'll commit the patch after ...

9 years, 11 months ago (2011-01-25 12:27:40 UTC) #1

LGTM

Expand Messages | Collapse Messages