Issue 6264012: [NTP] Tweak app drag and drop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6264012: [NTP] Tweak app drag and drop. (Closed)

Created:
9 years, 11 months ago by jstritar

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/resources

Visibility:
Public.

Description

[NTP] Tweak app drag and drop. 1. Map the free space on the last row of the app launcher to the last valid app position. 2. Transition the app opacity smoothly. 3. Fix JS errors when starting drag from certain areas. 4. Make sure drag and drop works when the window / apps section is scrolled. BUG=70795 TEST=none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72394

Patch Set 1 #

Patch Set 2 : fix js error and scrolling #

Total comments: 2

Patch Set 3 : update if statement #

Patch Set 4 : fix another scrolling issue #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
M	chrome/browser/resources/ntp/apps.css	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	1 2 3	2 chunks	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/ntp/drag_drop_controller.js	View	1 2 3	4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

9 years, 11 months ago (2011-01-24 19:22:42 UTC) #2

lgtm w/ nits

http://codereview.chromium.org/6264012/diff/3001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/6264012/diff/3001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp/apps.js:370: if (!item ||
item.classList.contains('web-store-entry'))
Can the second half of this check happen now? If not, remove it.

http://codereview.chromium.org/6264012/diff/3001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp/apps.js:433: if (index >= appCount && index < cols
* rows)
Cool. This was a good benefit of moving getIndexAt_ into this class.

Expand Messages | Collapse Messages