Issue 6264007: Fix instant test on Mac: use cgi.parse_qs() instead of urlparse.urlparse()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6264007: Fix instant test on Mac: use cgi.parse_qs() instead of urlparse.urlparse() (Closed)

Created:
9 years, 11 months ago by Huyen

Modified:
9 years, 6 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, dyu1, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix instant test on Mac: use cgi.parse_qs() instead of urlparse.urlparse() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72088

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/test/functional/instant.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

LGTM http://codereview.chromium.org/6264007/diff/1/chrome/test/functional/instant.py File chrome/test/functional/instant.py (right): http://codereview.chromium.org/6264007/diff/1/chrome/test/functional/instant.py#newcode11 chrome/test/functional/instant.py:11: import cgi move this before import os

9 years, 11 months ago (2011-01-21 02:02:38 UTC) #1

Huyen

9 years, 11 months ago (2011-01-21 02:07:48 UTC) #3

Thanks!

http://codereview.chromium.org/6264007/diff/1/chrome/test/functional/instant.py
File chrome/test/functional/instant.py (right):

http://codereview.chromium.org/6264007/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:11: import cgi
On 2011/01/21 02:02:38, Nirnimesh wrote:
> move this before import os

Done.

Expand Messages | Collapse Messages

Issue 6264007: Fix instant test on Mac: use cgi.parse_qs() instead of urlparse.urlparse() (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages